public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* Pointer dereference before NULL check in ACPI thermal driver.
@ 2004-09-03 21:13 Dave Jones
  0 siblings, 0 replies; only message in thread
From: Dave Jones @ 2004-09-03 21:13 UTC (permalink / raw)
  To: len.brown; +Cc: Linux Kernel

Again, found with coverity's checker.

Signed-off-by: Dave Jones <davej@redhat.com>

--- linux-2.6.8/drivers/acpi/thermal.c~	2004-09-03 22:11:22.630428496 +0100
+++ linux-2.6.8/drivers/acpi/thermal.c	2004-09-03 22:11:44.392120216 +0100
@@ -659,7 +659,7 @@
 	struct acpi_thermal	*tz = (struct acpi_thermal *) data;
 	unsigned long		sleep_time = 0;
 	int			i = 0;
-	struct acpi_thermal_state state = tz->state;
+	struct acpi_thermal_state state;
 
 	ACPI_FUNCTION_TRACE("acpi_thermal_check");
 
@@ -668,6 +668,8 @@
 		return_VOID;
 	}
 
+	state = tz->state;
+
 	result = acpi_thermal_get_temperature(tz);
 	if (result)
 		return_VOID;

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2004-09-03 21:19 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-09-03 21:13 Pointer dereference before NULL check in ACPI thermal driver Dave Jones

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox