From: Dave Jones <davej@redhat.com>
To: Bartlomiej Zolnierkiewicz <bzolnier@elka.pw.edu.pl>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: hpt366 ptr use before NULL check.
Date: Fri, 3 Sep 2004 23:28:31 +0100 [thread overview]
Message-ID: <20040903222831.GA29492@redhat.com> (raw)
In-Reply-To: <200409040017.08272.bzolnier@elka.pw.edu.pl>
On Sat, Sep 04, 2004 at 12:17:07AM +0200, Bartlomiej Zolnierkiewicz wrote:
>
> bogus, hwif can't be NULL
> please remove checks instead
As you wish.
Signed-off-by: Dave Jones <davej@redhat.com>
--- latest-FC2/drivers/ide/pci/hpt366.c~ 2004-09-03 23:26:29.092342152 +0100
+++ latest-FC2/drivers/ide/pci/hpt366.c 2004-09-03 23:27:28.249348920 +0100
@@ -777,9 +777,6 @@
u8 reg59h = 0, reset = (hwif->channel) ? 0x80 : 0x40;
u8 regXXh = 0, state_reg= (hwif->channel) ? 0x57 : 0x53;
- if (!hwif)
- return -EINVAL;
-
// hwif->bus_state = state;
pci_read_config_byte(dev, 0x59, ®59h);
@@ -813,9 +810,6 @@
u8 tristate = 0, resetmask = 0, bus_reg = 0;
u16 tri_reg;
- if (!hwif)
- return -EINVAL;
-
hwif->bus_state = state;
if (hwif->channel) {
prev parent reply other threads:[~2004-09-03 22:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-03 21:15 hpt366 ptr use before NULL check Dave Jones
2004-09-03 21:53 ` Dave Jones
2004-09-03 22:17 ` Bartlomiej Zolnierkiewicz
2004-09-03 22:28 ` Dave Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040903222831.GA29492@redhat.com \
--to=davej@redhat.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=bzolnier@elka.pw.edu.pl \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox