From: Jens Axboe <axboe@suse.de>
To: Neil Brown <neilb@cse.unsw.edu.au>
Cc: Christoph Hellwig <hch@lst.de>, linux-kernel@vger.kernel.org
Subject: Re: bug in md write barrier support?
Date: Sat, 4 Sep 2004 10:21:21 +0200 [thread overview]
Message-ID: <20040904082121.GB2343@suse.de> (raw)
In-Reply-To: <16697.4817.621088.474648@cse.unsw.edu.au>
On Sat, Sep 04 2004, Neil Brown wrote:
> On Friday September 3, hch@lst.de wrote:
> > md_flush_mddev just passes on the sector relative to the raid device,
> > shouldn't it be translated somewhere?
>
> Yes. md_flush_mddev should simply be removed.
> The functionality should be, and largely is, in the individual
> personalities.
Yes, sorry I was a little lazy there even though I followed the plugging
conversion :(
> Is there documentation somewhere on exactly what an issue_flush_fn
> should do (is it allowed to sleep? what must happen before it is
> allowed to return, what is the "error_sector" for, that sort of thing).
It is allowed to sleep, you should return when the flush is complete.
error_sector is the failed location, which really should be a dev,sector
tupple.
--
Jens Axboe
next prev parent reply other threads:[~2004-09-04 8:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-03 17:24 bug in md write barrier support? Christoph Hellwig
2004-09-04 0:56 ` Neil Brown
2004-09-04 8:21 ` Jens Axboe [this message]
2004-09-06 1:36 ` Neil Brown
2004-09-08 9:23 ` Jens Axboe
2004-09-08 13:35 ` Alan Cox
2004-09-08 15:46 ` Jens Axboe
2004-09-08 22:21 ` Alan Cox
2004-09-09 8:06 ` Jens Axboe
2004-09-09 8:22 ` Arjan van de Ven
2004-09-09 8:29 ` Jens Axboe
2004-09-09 12:51 ` Alan Cox
2004-09-09 14:34 ` Jens Axboe
2004-09-12 17:13 ` Rogier Wolff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040904082121.GB2343@suse.de \
--to=axboe@suse.de \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@cse.unsw.edu.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox