Re: [PATCH] removes unnessary print of space

Andrew Morton
2004-09-06T08:32:11Z

Kirill Korotaev <dev@sw.ru> wrote:
>
> I've noticed another thing. There is a default bust_spinlocks() in
> lib/bust_spinlocks.c. 4 architectures including x86 have their own
> copies of it, which are exactly the same as the default one.
>
> So do we really need lib/bust_spinlocks.c or we can move a signle copy
> of this function to kernel/printk.c?

I'd leave it as is - nobody's complaining.

In the more modern scheme of things we'd move that file to kernel/ and
require that per-arch Kconfigs define CONFIG_NEED_GENERIC_BUST_SPINLOCKS,
then use that in kernel/Makefile. But doing that now would be gratuitous
noise, IMO.