Re: [PATCH] removes unnessary print of space

Kirill Korotaev
2004-09-06T08:22:55Z

>>This patch removes unnessary print of space in bust_spinlocks().
>> printk("") wakeups klogd as well,
>
> Until some smarty comes along and optimises printk() to skip empty strings.
>
> An explicit wake_up_klogd() thing might make sense, rather than relying
> upon side-effects.
yup, you are right. I was the easiest, but not the best.
I'll make a patch with wakeup_klogd.

>>no need to print a space and make a mess.
> Can't say that I've ever noticed that space.
We did. Many times.

I've noticed another thing. There is a default bust_spinlocks() in
lib/bust_spinlocks.c. 4 architectures including x86 have their own
copies of it, which are exactly the same as the default one.

So do we really need lib/bust_spinlocks.c or we can move a signle copy
of this function to kernel/printk.c?

Kirill