* drivers/cdrom/cdu31a.c broken
@ 2004-09-06 14:02 Olaf Hering
0 siblings, 0 replies; 2+ messages in thread
From: Olaf Hering @ 2004-09-06 14:02 UTC (permalink / raw)
To: linux-kernel, Andrew Morton
ChangeSet
1.1998 04/09/03 10:36:31 janitor@sternwelten.at[torvalds] +1 -0
[PATCH] cdu31a: replace schedule_timeout() with msleep()
typo, should be ; instead of :
diff -purN linux-2.6.9-rc1-bk13.orig/drivers/cdrom/cdu31a.c linux-2.6.9-rc1-bk13/drivers/cdrom/cdu31a.c
--- linux-2.6.9-rc1-bk13.orig/drivers/cdrom/cdu31a.c 2004-09-06 15:23:34.000000000 +0200
+++ linux-2.6.9-rc1-bk13/drivers/cdrom/cdu31a.c 2004-09-06 15:59:32.549300720 +0200
@@ -959,7 +959,7 @@ retry_cd_operation:
if (((result_buffer[0] & 0xf0) == 0x20)
&& (num_retries < MAX_CDU31A_RETRIES)) {
num_retries++;
- msleep(100):
+ msleep(100);
goto retry_cd_operation;
}
--
USB is for mice, FireWire is for men!
sUse lINUX ag, nÜRNBERG
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: drivers/cdrom/cdu31a.c broken
@ 2004-09-06 15:32 Margit Schubert-While
0 siblings, 0 replies; 2+ messages in thread
From: Margit Schubert-While @ 2004-09-06 15:32 UTC (permalink / raw)
To: linux-kernel
Olaf scribeth:
> typo, should be ; instead of :
I wonder how that happened having been signed off by no less
than 4 people ?! ;-)
Which raises a couple of other questions regarding the
schedule_timeout -> msleep changes:
Is it correct to replace a TASK_INTERRUPTIBLE schedule_timeout
with msleep which is TASK_UNINTERRUPTIBLE ?
Did anyone check if the relevant pieces of code are under control
of a wait queue ?
Margit
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-09-06 15:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-09-06 14:02 drivers/cdrom/cdu31a.c broken Olaf Hering
-- strict thread matches above, loose matches on Subject: below --
2004-09-06 15:32 Margit Schubert-While
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox