public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [Patch 2.6.9-rc1-bk11] cdu31a: fix msleep patch typo
@ 2004-09-05 17:25 Adam J. Richter
  2004-09-06 19:50 ` maks attems
  0 siblings, 1 reply; 2+ messages in thread
From: Adam J. Richter @ 2004-09-05 17:25 UTC (permalink / raw)
  To: janitor, minyard, nacc; +Cc: linux-kernel

	linux-2.6.9-rc1-bk11 integrated the patch "cdu31a: replace
schedule_timeout() with msleep()".  That patch contained a typo,
causing the cdu31a driver to fail to compile.  Here is a fix for
the typo.

	Of course I have tested this patch to verify that it compiles.
I do not, however, have a Sony cdu-31a or cdu-33a drive handy to actually
test that the driver works.  I wonder if anyone out there still has a
Sony cdu-31a or cdu-33a CD-ROM drive on a machine running Linux.

Signed-off-by:	Adam J. Richter <adam@yggdrasil.com>

                    __     ______________ 
Adam J. Richter        \ /
adam@yggdrasil.com      | g g d r a s i l


--- linux-2.6.9-rc1-bk11/drivers/cdrom/cdu31a.c	2004-09-05 09:11:23.000000000 -0700
+++ linux/drivers/cdrom/cdu31a.c	2004-09-05 10:09:42.000000000 -0700
@@ -959,7 +959,7 @@
 	if (((result_buffer[0] & 0xf0) == 0x20)
 	    && (num_retries < MAX_CDU31A_RETRIES)) {
 		num_retries++;
-		msleep(100):
+		msleep(100);
 		goto retry_cd_operation;
 	}
 

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [Patch 2.6.9-rc1-bk11] cdu31a: fix msleep patch typo
  2004-09-05 17:25 [Patch 2.6.9-rc1-bk11] cdu31a: fix msleep patch typo Adam J. Richter
@ 2004-09-06 19:50 ` maks attems
  0 siblings, 0 replies; 2+ messages in thread
From: maks attems @ 2004-09-06 19:50 UTC (permalink / raw)
  To: Adam J. Richter; +Cc: minyard, nacc, linux-kernel

On Sun, 05 Sep 2004, Adam J. Richter wrote:

> 	linux-2.6.9-rc1-bk11 integrated the patch "cdu31a: replace
> schedule_timeout() with msleep()".  That patch contained a typo,
> causing the cdu31a driver to fail to compile.  Here is a fix for
> the typo.

thanks it already got reported,
similiar patch from adrian bunk is on the way to be merged.
 
> 	Of course I have tested this patch to verify that it compiles.
> I do not, however, have a Sony cdu-31a or cdu-33a drive handy to actually
> test that the driver works.  I wonder if anyone out there still has a
> Sony cdu-31a or cdu-33a CD-ROM drive on a machine running Linux.
> 
> Signed-off-by:	Adam J. Richter <adam@yggdrasil.com>

wooow cool :)
sounds like you volounteer to maintain that beast?
do you want to be added to MAINTAINERS?


--
maks
kernel janitor  	http://janitor.kernelnewbies.org/


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2004-09-06 19:50 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-09-05 17:25 [Patch 2.6.9-rc1-bk11] cdu31a: fix msleep patch typo Adam J. Richter
2004-09-06 19:50 ` maks attems

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox