From: Vojtech Pavlik <vojtech@suse.cz>
To: Dmitry Torokhov <dtor_core@ameritech.net>
Cc: Bjorn Helgaas <bjorn.helgaas@hp.com>,
Alessandro Rubini <rubini@ipvvis.unipv.it>,
linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] allow i8042 register location override
Date: Mon, 6 Sep 2004 21:58:42 +0200 [thread overview]
Message-ID: <20040906195841.GA1048@ucw.cz> (raw)
In-Reply-To: <200409061328.31045.dtor_core@ameritech.net>
On Mon, Sep 06, 2004 at 01:28:30PM -0500, Dmitry Torokhov wrote:
> On Monday 06 September 2004 07:22 am, Vojtech Pavlik wrote:
> > On Fri, Sep 03, 2004 at 09:41:24AM -0600, Bjorn Helgaas wrote:
> > > On Friday 03 September 2004 12:57 am, Dmitry Torokhov wrote:
> > > > What do you think about the patch below? I renamed some function/variable
> > > > names to be more in line with the rest of i8042 code, other than that
> > > > its pretty much your code.
> > >
> > > That looks great to me, and it works fine on my DL360.
> > >
> > > My only comment is that in an ideal world, we would not have to
> > > change any drivers if a new architecture started supporting ACPI.
> > > With the current patch, we'd have to twiddle some of the i8042-XXX.h
> > > files a bit. But I don't think it's worth the trouble of restructuring
> > > them to fix that.
> > >
> > > Thanks for all your help!
> >
> > One bug that I could spot immediately is that the patch sets i8042_reset
> > on i386. This doesn't seem intentional, and is quite wrong, too, since
> > on some older machines it confuses the BIOS.
>
> Nope it does not. It is only on IA64:
>
> > +#if defined(__ia64__)
> > + i8042_reset = 1;
> > +#endif
> which is in i8042-x86ia64io.h
>
> This fragment is in i8042-io.h which is not included in by Intel-originated
> arches anymore.
>
> > -#if !defined(__i386__) && !defined(__x86_64__)
> > i8042_reset = 1;
> > -#endif
>
> Did I miss something?
No, sorry, I did. I didn't notice the fact that i8042-io.h is not used
on i386 at all.
--
Vojtech Pavlik
SuSE Labs, SuSE CR
next prev parent reply other threads:[~2004-09-06 19:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-02 17:56 [PATCH] allow i8042 register location override Dmitry Torokhov
2004-09-02 21:29 ` Bjorn Helgaas
2004-09-03 6:57 ` Dmitry Torokhov
2004-09-03 15:41 ` Bjorn Helgaas
2004-09-06 12:22 ` Vojtech Pavlik
2004-09-06 18:28 ` Dmitry Torokhov
2004-09-06 19:58 ` Vojtech Pavlik [this message]
-- strict thread matches above, loose matches on Subject: below --
2004-09-02 16:09 Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040906195841.GA1048@ucw.cz \
--to=vojtech@suse.cz \
--cc=akpm@osdl.org \
--cc=bjorn.helgaas@hp.com \
--cc=dtor_core@ameritech.net \
--cc=linux-kernel@vger.kernel.org \
--cc=rubini@ipvvis.unipv.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox