From: Jens Axboe <axboe@suse.de>
To: Paul Mackerras <paulus@samba.org>
Cc: Jesper Juhl <juhl-lkml@dif.dk>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] remember to check return value from __copy_to_user() in cdrom_read_cdda_old()
Date: Tue, 7 Sep 2004 11:58:33 +0200 [thread overview]
Message-ID: <20040907095833.GM6323@suse.de> (raw)
In-Reply-To: <16701.32784.10441.884090@cargo.ozlabs.ibm.com>
On Tue, Sep 07 2004, Paul Mackerras wrote:
> Jens Axboe writes:
>
> > __copy_to_user is the unchecking version of copy_to_user.
>
> It doesn't range-check the address, but it does return non-zero
> (number of bytes not copied) if it encounters a fault writing to the
> user buffer.
I don't see your point. We already access checked the range, so if
__copy_to_user() returns non-zero, the application is buggy.
--
Jens Axboe
prev parent reply other threads:[~2004-09-07 9:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-06 21:46 [PATCH] remember to check return value from __copy_to_user() in cdrom_read_cdda_old() Jesper Juhl
2004-09-07 8:02 ` Jens Axboe
2004-09-07 9:32 ` Paul Mackerras
2004-09-07 9:34 ` Jens Axboe
2004-09-07 9:59 ` Andrew Morton
2004-09-07 10:09 ` Jens Axboe
2004-09-07 10:12 ` Andrew Morton
2004-09-07 10:15 ` Jens Axboe
2004-09-07 10:23 ` viro
2004-09-07 10:30 ` Jens Axboe
2004-09-07 10:45 ` viro
2004-09-07 11:42 ` Jens Axboe
2004-09-07 9:58 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040907095833.GM6323@suse.de \
--to=axboe@suse.de \
--cc=juhl-lkml@dif.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox