From: Christoph Hellwig <hch@lst.de>
To: akpm@osdl.org
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] don't export blkdev_open and def_blk_ops
Date: Tue, 7 Sep 2004 16:31:30 +0200 [thread overview]
Message-ID: <20040907143130.GA8358@lst.de> (raw)
Already since 2.4 all block devices use block_device_operations and
shouldn't deal with file operations directly.
--- 1.163/fs/block_dev.c 2004-06-29 16:44:49 +02:00
+++ edited/fs/block_dev.c 2004-09-07 13:26:09 +02:00
@@ -666,7 +666,7 @@
EXPORT_SYMBOL(blkdev_get);
-int blkdev_open(struct inode * inode, struct file * filp)
+static int blkdev_open(struct inode * inode, struct file * filp)
{
struct block_device *bdev;
int res;
@@ -695,8 +695,6 @@
return res;
}
-EXPORT_SYMBOL(blkdev_open);
-
int blkdev_put(struct block_device *bdev)
{
int ret = 0;
@@ -797,8 +795,6 @@
.writev = generic_file_write_nolock,
.sendfile = generic_file_sendfile,
};
-
-EXPORT_SYMBOL(def_blk_fops);
int ioctl_by_bdev(struct block_device *bdev, unsigned cmd, unsigned long arg)
{
--- 1.343/include/linux/fs.h 2004-08-27 08:30:32 +02:00
+++ edited/include/linux/fs.h 2004-09-07 13:40:30 +02:00
@@ -1251,7 +1251,6 @@
extern void bd_set_size(struct block_device *, loff_t size);
extern void bd_forget(struct inode *inode);
extern void bdput(struct block_device *);
-extern int blkdev_open(struct inode *, struct file *);
extern struct block_device *open_by_devnum(dev_t, unsigned);
extern struct file_operations def_blk_fops;
extern struct address_space_operations def_blk_aops;
reply other threads:[~2004-09-07 14:33 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040907143130.GA8358@lst.de \
--to=hch@lst.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox