[PATCH] sched.c gratious export removal

[PATCH] sched.c gratious export removal

[Christoph Hellwig]

sched.c exports a few internal helpers although none of them is used in
modular code or code that could easily be made modular, nor would we
want modules to use them.


--- 1.345/kernel/sched.c	2004-09-04 04:28:36 +02:00
+++ edited/kernel/sched.c	2004-09-07 15:57:22 +02:00
@@ -1036,8 +1036,6 @@
 	preempt_enable();
 }
 
-EXPORT_SYMBOL_GPL(kick_process);
-
 /*
  * Return a low guess at the load of a migration-source cpu.
  *
@@ -2908,7 +2906,6 @@
 	__wake_up_common(q, mode, nr_exclusive, sync, NULL);
 	spin_unlock_irqrestore(&q->lock, flags);
 }
-EXPORT_SYMBOL_GPL(__wake_up_sync);	/* For internal use only */
 
 void fastcall complete(struct completion *x)
 {
@@ -3142,8 +3139,6 @@
 	return TASK_NICE(p);
 }
 
-EXPORT_SYMBOL(task_nice);
-
 /**
  * idle_cpu - is a given cpu idle currently?
  * @cpu: the processor in question.
@@ -3152,8 +3147,6 @@
 {
 	return cpu_curr(cpu) == cpu_rq(cpu)->idle;
 }
-
-EXPORT_SYMBOL_GPL(idle_cpu);
 
 /**
  * find_process_by_pid - find a process with a matching PID value.

Re: [PATCH] sched.c gratious export removal

[Alan Cox]

On Maw, 2004-09-07 at 15:58, Christoph Hellwig wrote:
> sched.c exports a few internal helpers although none of them is used in
> modular code or code that could easily be made modular, nor would we
> want modules to use them.

>  /**
>   * idle_cpu - is a given cpu idle currently?
>   * @cpu: the processor in question.
> @@ -3152,8 +3147,6 @@
>  {
>  	return cpu_curr(cpu) == cpu_rq(cpu)->idle;
>  }
> -
> -EXPORT_SYMBOL_GPL(idle_cpu);

External power management modules definitely want to know this.