From: Andreas Dilger <adilger@clusterfs.com>
To: Christoph Hellwig <hch@lst.de>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
akpm@osdl.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] unexport get_wchan
Date: Tue, 7 Sep 2004 13:38:19 -0600 [thread overview]
Message-ID: <20040907193819.GS27331@schnapps.adilger.int> (raw)
In-Reply-To: <20040907184907.GA13331@lst.de>
[-- Attachment #1: Type: text/plain, Size: 816 bytes --]
On Sep 07, 2004 20:49 +0200, Christoph Hellwig wrote:
> Well, you kdb cotains quite a few other patches to core code already,
> no? And it could add back a single EXPORT_SYMBOL in a common place
> instead of duplicated over every architecture..
I think most projects' goals is to reduce the number of patches they need
to make to the kernel instead of increasing them... If you think it is
ugly to have multiple EXPORT_SYMBOLS() then it should just be moved to
the line after the function definition. Having to add another configure
rule to check for now-unexported symbols isn't my idea of time well spent
(not that I care about this one in particular).
Cheers, Andreas
--
Andreas Dilger
http://sourceforge.net/projects/ext2resize/
http://members.shaw.ca/adilger/ http://members.shaw.ca/golinux/
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2004-09-07 19:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-07 14:45 [PATCH] unexport get_wchan Christoph Hellwig
2004-09-07 17:07 ` Alan Cox
2004-09-07 18:11 ` Christoph Hellwig
2004-09-07 17:29 ` Alan Cox
2004-09-07 18:49 ` Christoph Hellwig
2004-09-07 19:38 ` Andreas Dilger [this message]
2004-09-07 18:59 ` Arjan van de Ven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040907193819.GS27331@schnapps.adilger.int \
--to=adilger@clusterfs.com \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox