public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jesse Barnes <jbarnes@engr.sgi.com>
To: Paul Jackson <pj@sgi.com>
Cc: Linus Torvalds <torvalds@osdl.org>,
	Tony Luck <tony.luck@intel.com>,
	ianw@gelato.unsw.edu.au, William Irwin <wli@holomorphy.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] SN2 build fix CONFIG_VIRTUAL_MEM_MAP and CONFIG_DISCONTIGMEM
Date: Tue, 7 Sep 2004 21:30:38 -0700	[thread overview]
Message-ID: <200409072130.38480.jbarnes@engr.sgi.com> (raw)
In-Reply-To: <20040905211837.3068.64652.58313@sam.engr.sgi.com>

On Sunday, September 5, 2004 2:18 pm, Paul Jackson wrote:
> The change on 2004-09-03 by ianw@gelato.unsw.edu.au appears to have
> a typo, which causes builds of configurations which define both
> CONFIG_VIRTUAL_MEM_MAP and CONFIG_DISCONTIGMEM to emit some 890
> warnings for redefines of each of pfn_valid, page_to_pfn,
> pfn_to_page.  This shows up compiling sn2_defconfig, the SN2
> config of arch ia64.  I believe that this is a simply typo,
> an extra "#else" line.  Removing this exta line enables sn2_defconfig
> to build as before.  Builds of other arch's untested.  No effort
> made to boot this.
>
> Signed-off-by: Paul Jackson <pj@sgi.com>

Thanks Paul, this looks a little simpler than the patch I posted (I'd rather 
just make CONFIG_DISCONTIGMEM and CONFIG_VIRTUAL_MEMMAP mandatory on ia64, 
but that's for another patch).  Linus, since this breakage is in your tree 
now, can you please apply this assuming Tony has no complaints so that people 
can build on ia64 again?

Thanks,
Jesse

  reply	other threads:[~2004-09-08  4:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-09-05 21:18 [PATCH] SN2 build fix CONFIG_VIRTUAL_MEM_MAP and CONFIG_DISCONTIGMEM Paul Jackson
2004-09-08  4:30 ` Jesse Barnes [this message]
  -- strict thread matches above, loose matches on Subject: below --
2004-09-08 16:56 Luck, Tony
2004-09-08 21:45 tony.luck
2004-09-08 22:53 ` Paul Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200409072130.38480.jbarnes@engr.sgi.com \
    --to=jbarnes@engr.sgi.com \
    --cc=ianw@gelato.unsw.edu.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pj@sgi.com \
    --cc=tony.luck@intel.com \
    --cc=torvalds@osdl.org \
    --cc=wli@holomorphy.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox