* [patch 2/3] uml-ubd-any-elevator
@ 2004-09-06 17:44 blaisorblade_spam
2004-09-08 9:23 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: blaisorblade_spam @ 2004-09-06 17:44 UTC (permalink / raw)
To: akpm; +Cc: jdike, linux-kernel, user-mode-linux-devel, blaisorblade_spam
Avoid forcing use of the no-op scheduler for UBD; this may uncover some bugs in the
UBD driver, and in fact uml-ubd-no-empty-queue.patch is needed to make this sure.
But as of now, no other bugs have been discovered, so this should be safe.
Signed-off-by: Paolo 'Blaisorblade' Giarrusso <blaisorblade_spam@yahoo.it>
---
uml-linux-2.6.8.1-paolo/arch/um/drivers/ubd_kern.c | 2 --
1 files changed, 2 deletions(-)
diff -puN arch/um/drivers/ubd_kern.c~uml-ubd-any-elevator arch/um/drivers/ubd_kern.c
--- uml-linux-2.6.8.1/arch/um/drivers/ubd_kern.c~uml-ubd-any-elevator 2004-08-29 14:40:53.731043416 +0200
+++ uml-linux-2.6.8.1-paolo/arch/um/drivers/ubd_kern.c 2004-08-29 14:40:53.733043112 +0200
@@ -749,8 +749,6 @@ int ubd_init(void)
return -1;
}
- elevator_init(ubd_queue, &elevator_noop);
-
if (fake_major != MAJOR_NR) {
char name[sizeof("ubd_nnn\0")];
_
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [patch 2/3] uml-ubd-any-elevator
2004-09-06 17:44 [patch 2/3] uml-ubd-any-elevator blaisorblade_spam
@ 2004-09-08 9:23 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2004-09-08 9:23 UTC (permalink / raw)
To: blaisorblade_spam; +Cc: akpm, jdike, linux-kernel, user-mode-linux-devel
On Mon, Sep 06 2004, blaisorblade_spam@yahoo.it wrote:
> diff -puN arch/um/drivers/ubd_kern.c~uml-ubd-any-elevator arch/um/drivers/ubd_kern.c
> --- uml-linux-2.6.8.1/arch/um/drivers/ubd_kern.c~uml-ubd-any-elevator 2004-08-29 14:40:53.731043416 +0200
> +++ uml-linux-2.6.8.1-paolo/arch/um/drivers/ubd_kern.c 2004-08-29 14:40:53.733043112 +0200
> @@ -749,8 +749,6 @@ int ubd_init(void)
> return -1;
> }
>
> - elevator_init(ubd_queue, &elevator_noop);
> -
> if (fake_major != MAJOR_NR) {
> char name[sizeof("ubd_nnn\0")];
if this is not applied, at least the file needs an elevator_exit(q);
before calling elevator_init() for the new elevator. otherwise the
original elevator data is leaked.
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-09-08 9:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-09-06 17:44 [patch 2/3] uml-ubd-any-elevator blaisorblade_spam
2004-09-08 9:23 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox