From: Christoph Hellwig <hch@infradead.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Christoph Hellwig <hch@infradead.org>,
Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org
Subject: Re: [patch] preempt-smp.patch, 2.6.9-rc1-bk14
Date: Wed, 8 Sep 2004 13:41:52 +0100 [thread overview]
Message-ID: <20040908134152.A31413@infradead.org> (raw)
In-Reply-To: <20040908114446.GA14286@elte.hu>; from mingo@elte.hu on Wed, Sep 08, 2004 at 01:44:46PM +0200
On Wed, Sep 08, 2004 at 01:44:46PM +0200, Ingo Molnar wrote:
>
> * Christoph Hellwig <hch@infradead.org> wrote:
>
> > > NOTE to architecture maintainers: generic_raw_read_trylock() is a crude
> > > version that should be replaced with the proper arch-optimized version
> > > ASAP.
> >
> > I'd suggest not providing it at all then, because that forces arch
> > maintainers to implement it.
>
> while generic it's actually correct for the purpose it's being used for
> right now and all architectures should thus compile & work fine.
Well, if it goes into -mm I'd rather see it not commpile first and let
arch maintainers do proper version instead of forgetting it. And
unless I misread the code it's only used for SMP && PREEMPT anyway, right?
next prev parent reply other threads:[~2004-09-08 12:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-08 11:17 [patch] preempt-smp.patch, 2.6.9-rc1-bk14 Ingo Molnar
2004-09-08 11:40 ` Christoph Hellwig
2004-09-08 11:44 ` Ingo Molnar
2004-09-08 12:41 ` Christoph Hellwig [this message]
2004-09-08 12:47 ` Ingo Molnar
2004-09-08 12:53 ` Zwane Mwaikambo
2004-09-08 12:53 ` Ingo Molnar
2004-09-08 13:01 ` Ingo Molnar
2004-09-08 13:28 ` Zwane Mwaikambo
2004-09-13 10:18 ` [patch] preempt-smp.patch, 2.6.9-rc1-mm5 Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040908134152.A31413@infradead.org \
--to=hch@infradead.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox