From: "David S. Miller" <davem@davemloft.net>
To: "Miquel van Smoorenburg" <miquels@cistron.nl>
Cc: linux-kernel@vger.kernel.org
Subject: Re: 2.6.9-rc1-bk15: kernel BUG at net/ipv4/tcp_output.c:271!
Date: Thu, 9 Sep 2004 09:07:43 -0700 [thread overview]
Message-ID: <20040909090743.7c39c3ee.davem@davemloft.net> (raw)
In-Reply-To: <chpgok$pdq$1@news.cistron.nl>
On Thu, 9 Sep 2004 12:02:28 +0000 (UTC)
"Miquel van Smoorenburg" <miquels@cistron.nl> wrote:
> I tried 2.6.9-rc1-bk15 on one of my servers, and it soon crashes
> with "kernel BUG at net/ipv4/tcp_output.c:271!". 2.6.9-rc1
> is fine. Line 271 is
>
> BUG_ON(!TCP_SKB_CB(skb)->tso_factor);
>
> .. it appears that the tso_factor stuff was added somewhere
> after 2.6.9-rc1.
Thanks for the report (although please use netdev@oss.sgi.com
next time). The patch below should fix it.
===== net/ipv4/tcp_output.c 1.52 vs edited =====
--- 1.52/net/ipv4/tcp_output.c 2004-09-09 08:37:00 -07:00
+++ edited/net/ipv4/tcp_output.c 2004-09-09 08:47:27 -07:00
@@ -434,7 +434,7 @@
unsigned int factor;
factor = skb->len + (mss_std - 1);
- factor /= mss;
+ factor /= mss_std;
TCP_SKB_CB(skb)->tso_factor = factor;
}
}
prev parent reply other threads:[~2004-09-09 16:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-09 12:02 2.6.9-rc1-bk15: kernel BUG at net/ipv4/tcp_output.c:271! Miquel van Smoorenburg
2004-09-09 16:07 ` David S. Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040909090743.7c39c3ee.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=miquels@cistron.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox