From: Jens Axboe <axboe@suse.de>
To: Bartlomiej Zolnierkiewicz <bzolnier@elka.pw.edu.pl>
Cc: Russell King <rmk+lkml@arm.linux.org.uk>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [patch][9/9] block: remove bio walking
Date: Thu, 9 Sep 2004 16:31:16 +0200 [thread overview]
Message-ID: <20040909143116.GX1737@suse.de> (raw)
In-Reply-To: <200409091553.13918.bzolnier@elka.pw.edu.pl>
On Thu, Sep 09 2004, Bartlomiej Zolnierkiewicz wrote:
> On Thursday 09 September 2004 10:03, Russell King wrote:
> > On Wed, Sep 08, 2004 at 09:27:04PM +0200, Bartlomiej Zolnierkiewicz wrote:
> > > [patch] block: remove bio walking
> > >
> > > IDE driver was the only user of bio walking code.
>
> was in -bk10 :-(
>
> > The MMC driver also uses this. Please don't remove.
>
> OK I'll just drop this patch but can't we also use scatterlists in MMC?
>
> The point is that I now think bio walking was a mistake and accessing
> bios directly from low-level drivers is a layering violation (thus
> all the added complexity). Moreover with fixed IDE PIO and without
> bio walking code it should be possible to shrink struct request by
> removing all "current" entries.
I agree, it's much nicer and it allows to drop the cbio fields in struct
request which is good.
--
Jens Axboe
prev parent reply other threads:[~2004-09-09 14:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-08 19:27 [patch][9/9] block: remove bio walking Bartlomiej Zolnierkiewicz
2004-09-09 8:03 ` Russell King
2004-09-09 13:53 ` Bartlomiej Zolnierkiewicz
2004-09-09 14:04 ` Russell King
2004-09-09 14:28 ` Bartlomiej Zolnierkiewicz
2004-09-09 14:54 ` Russell King
2004-09-09 15:44 ` Jens Axboe
2004-09-09 15:49 ` Jens Axboe
2004-09-09 16:01 ` David S. Miller
2004-09-09 17:10 ` Bartlomiej Zolnierkiewicz
2004-09-09 14:32 ` Jens Axboe
2004-09-09 14:31 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040909143116.GX1737@suse.de \
--to=axboe@suse.de \
--cc=bzolnier@elka.pw.edu.pl \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk+lkml@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox