From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S264937AbUIIOcl (ORCPT ); Thu, 9 Sep 2004 10:32:41 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S264917AbUIIOcl (ORCPT ); Thu, 9 Sep 2004 10:32:41 -0400 Received: from ns.virtualhost.dk ([195.184.98.160]:12501 "EHLO virtualhost.dk") by vger.kernel.org with ESMTP id S265044AbUIIOcb (ORCPT ); Thu, 9 Sep 2004 10:32:31 -0400 Date: Thu, 9 Sep 2004 16:31:16 +0200 From: Jens Axboe To: Bartlomiej Zolnierkiewicz Cc: Russell King , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [patch][9/9] block: remove bio walking Message-ID: <20040909143116.GX1737@suse.de> References: <200409082127.04331.bzolnier@elka.pw.edu.pl> <20040909090314.A24950@flint.arm.linux.org.uk> <200409091553.13918.bzolnier@elka.pw.edu.pl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200409091553.13918.bzolnier@elka.pw.edu.pl> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 09 2004, Bartlomiej Zolnierkiewicz wrote: > On Thursday 09 September 2004 10:03, Russell King wrote: > > On Wed, Sep 08, 2004 at 09:27:04PM +0200, Bartlomiej Zolnierkiewicz wrote: > > > [patch] block: remove bio walking > > > > > > IDE driver was the only user of bio walking code. > > was in -bk10 :-( > > > The MMC driver also uses this. Please don't remove. > > OK I'll just drop this patch but can't we also use scatterlists in MMC? > > The point is that I now think bio walking was a mistake and accessing > bios directly from low-level drivers is a layering violation (thus > all the added complexity). Moreover with fixed IDE PIO and without > bio walking code it should be possible to shrink struct request by > removing all "current" entries. I agree, it's much nicer and it allows to drop the cbio fields in struct request which is good. -- Jens Axboe