Re: [PATCH] cacheline align pagevec structure

Andrew Morton
2004-09-09T23:17:06Z

Marcelo Tosatti <marcelo.tosatti@cyclades.com> wrote:
>
> > I think the patch make sense, but I'm very sceptical about the benchmarks
> > ;)
>
> Why's that? You think changing to the number of pages in the pagevec to "15" instead
> "16" is the cause?

Nope. I wouldn't have expected to see a significant (or even measurable)
change in performance as a result of this patch.

After all, these structures are always stack-allocated, and top-of-stack is
most always in L1 cache.

I'd suspect that benchmark variability is the cause here.