public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* another oops, this time in 2.6.9-rc1-mm4
@ 2004-09-09  5:07 Gene Heskett
  2004-09-09  6:38 ` Greg KH
  0 siblings, 1 reply; 5+ messages in thread
From: Gene Heskett @ 2004-09-09  5:07 UTC (permalink / raw)
  To: linux-kernel

Greetings;

I just had to reboot back to -mm2 after playing with some printer configs in
cups, although the test pages worked, so I'm not sure what this all about,
from var log/messages:

Sep  8 23:13:42 coyote cups: cupsd -HUP succeeded
Sep  8 23:13:43 coyote kernel: usb_unlink_urb() is deprecated for synchronous unlinks.  Use usb_kill_urb()
Sep  8 23:13:43 coyote kernel: Badness in usb_unlink_urb at drivers/usb/core/urb.c:456
Sep  8 23:13:44 coyote kernel:  [<c01048ce>] dump_stack+0x1e/0x20
Sep  8 23:13:44 coyote kernel:  [<c0295f35>] usb_unlink_urb+0x85/0xa0
Sep  8 23:13:44 coyote kernel:  [<c02a7447>] usblp_unlink_urbs+0x17/0x40
Sep  8 23:13:44 coyote kernel:  [<c02a74a8>] usblp_release+0x38/0x60
Sep  8 23:13:44 coyote kernel:  [<c01501ea>] __fput+0x12a/0x140
Sep  8 23:13:44 coyote kernel:  [<c014e8e7>] filp_close+0x57/0x80
Sep  8 23:13:44 coyote kernel:  [<c014e971>] sys_close+0x61/0x90
Sep  8 23:13:44 coyote kernel:  [<c010425d>] sysenter_past_esp+0x52/0x71

repeat about 40-50 times before I rebooted cause it was very sluggish.

cups is 1.1.21-rc2, from rpm.

-- 
Cheers, Gene
"There are four boxes to be used in defense of liberty:
 soap, ballot, jury, and ammo. Please use in that order."
-Ed Howdershelt (Author)
99.25% setiathome rank, not too shabby for a WV hillbilly
Yahoo.com attorneys please note, additions to this message
by Gene Heskett are:
Copyright 2004 by Maurice Eugene Heskett, all rights reserved.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: another oops, this time in 2.6.9-rc1-mm4
  2004-09-09  5:07 another oops, this time in 2.6.9-rc1-mm4 Gene Heskett
@ 2004-09-09  6:38 ` Greg KH
  2004-09-09  9:34   ` Borislav Petkov
  2004-09-09 11:53   ` Gene Heskett
  0 siblings, 2 replies; 5+ messages in thread
From: Greg KH @ 2004-09-09  6:38 UTC (permalink / raw)
  To: Gene Heskett; +Cc: linux-kernel

On Thu, Sep 09, 2004 at 01:07:05AM -0400, Gene Heskett wrote:
> Greetings;
> 
> I just had to reboot back to -mm2 after playing with some printer configs in
> cups, although the test pages worked, so I'm not sure what this all about,
> from var log/messages:
> 
> Sep  8 23:13:42 coyote cups: cupsd -HUP succeeded
> Sep  8 23:13:43 coyote kernel: usb_unlink_urb() is deprecated for synchronous unlinks.  Use usb_kill_urb()
> Sep  8 23:13:43 coyote kernel: Badness in usb_unlink_urb at drivers/usb/core/urb.c:456
> Sep  8 23:13:44 coyote kernel:  [<c01048ce>] dump_stack+0x1e/0x20
> Sep  8 23:13:44 coyote kernel:  [<c0295f35>] usb_unlink_urb+0x85/0xa0
> Sep  8 23:13:44 coyote kernel:  [<c02a7447>] usblp_unlink_urbs+0x17/0x40
> Sep  8 23:13:44 coyote kernel:  [<c02a74a8>] usblp_release+0x38/0x60
> Sep  8 23:13:44 coyote kernel:  [<c01501ea>] __fput+0x12a/0x140
> Sep  8 23:13:44 coyote kernel:  [<c014e8e7>] filp_close+0x57/0x80
> Sep  8 23:13:44 coyote kernel:  [<c014e971>] sys_close+0x61/0x90
> Sep  8 23:13:44 coyote kernel:  [<c010425d>] sysenter_past_esp+0x52/0x71
> 
> repeat about 40-50 times before I rebooted cause it was very sluggish.

It's not a oops, it's a message that the driver needs to be fixed up,
and can be ignored safely (but sending a patch to fix the driver would
be even nicer...)

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: another oops, this time in 2.6.9-rc1-mm4
  2004-09-09  6:38 ` Greg KH
@ 2004-09-09  9:34   ` Borislav Petkov
  2004-09-09 17:14     ` Greg KH
  2004-09-09 11:53   ` Gene Heskett
  1 sibling, 1 reply; 5+ messages in thread
From: Borislav Petkov @ 2004-09-09  9:34 UTC (permalink / raw)
  To: Greg KH; +Cc: linux-kernel

[-- Attachment #1: Type: text/plain, Size: 1581 bytes --]

On Thursday 09 September 2004 08:38, Greg KH wrote:
> On Thu, Sep 09, 2004 at 01:07:05AM -0400, Gene Heskett wrote:
> > Greetings;
> >
> > I just had to reboot back to -mm2 after playing with some printer configs
> > in cups, although the test pages worked, so I'm not sure what this all
> > about, from var log/messages:
> >
> > Sep  8 23:13:42 coyote cups: cupsd -HUP succeeded
> > Sep  8 23:13:43 coyote kernel: usb_unlink_urb() is deprecated for
> > synchronous unlinks.  Use usb_kill_urb() Sep  8 23:13:43 coyote kernel:
> > Badness in usb_unlink_urb at drivers/usb/core/urb.c:456 Sep  8 23:13:44
> > coyote kernel:  [<c01048ce>] dump_stack+0x1e/0x20 Sep  8 23:13:44 coyote
> > kernel:  [<c0295f35>] usb_unlink_urb+0x85/0xa0 Sep  8 23:13:44 coyote
> > kernel:  [<c02a7447>] usblp_unlink_urbs+0x17/0x40 Sep  8 23:13:44 coyote
> > kernel:  [<c02a74a8>] usblp_release+0x38/0x60 Sep  8 23:13:44 coyote
> > kernel:  [<c01501ea>] __fput+0x12a/0x140
> > Sep  8 23:13:44 coyote kernel:  [<c014e8e7>] filp_close+0x57/0x80
> > Sep  8 23:13:44 coyote kernel:  [<c014e971>] sys_close+0x61/0x90
> > Sep  8 23:13:44 coyote kernel:  [<c010425d>] sysenter_past_esp+0x52/0x71
> >
> > repeat about 40-50 times before I rebooted cause it was very sluggish.
>
> It's not a oops, it's a message that the driver needs to be fixed up,
> and can be ignored safely (but sending a patch to fix the driver would
> be even nicer...)
>
> thanks,
>
> greg k-h
> -

Hi there Greg,
please be gentle, this is my first time :)
The situation looked trivial so I thought I should give it a try:

Regards,
Boris.

[-- Attachment #2: fix-usblp.patch --]
[-- Type: text/x-diff, Size: 482 bytes --]

--- drivers/usb/class/usblp.c.orig	2004-09-09 11:22:56.000000000 +0200
+++ drivers/usb/class/usblp.c	2004-09-09 11:24:11.000000000 +0200
@@ -410,9 +410,9 @@ static void usblp_cleanup (struct usblp 
 
 static void usblp_unlink_urbs(struct usblp *usblp)
 {
-	usb_unlink_urb(usblp->writeurb);
+	usb_kill_urb(usblp->writeurb);
 	if (usblp->bidir)
-		usb_unlink_urb(usblp->readurb);
+		usb_kill_urb(usblp->readurb);
 }
 
 static int usblp_release(struct inode *inode, struct file *file)

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: another oops, this time in 2.6.9-rc1-mm4
  2004-09-09  6:38 ` Greg KH
  2004-09-09  9:34   ` Borislav Petkov
@ 2004-09-09 11:53   ` Gene Heskett
  1 sibling, 0 replies; 5+ messages in thread
From: Gene Heskett @ 2004-09-09 11:53 UTC (permalink / raw)
  To: linux-kernel; +Cc: Greg KH

On Thursday 09 September 2004 02:38, Greg KH wrote:
>On Thu, Sep 09, 2004 at 01:07:05AM -0400, Gene Heskett wrote:
>> Greetings;
>>
>> I just had to reboot back to -mm2 after playing with some printer
>> configs in cups, although the test pages worked, so I'm not sure
>> what this all about, from var log/messages:
>>
>> Sep  8 23:13:42 coyote cups: cupsd -HUP succeeded
>> Sep  8 23:13:43 coyote kernel: usb_unlink_urb() is deprecated for
>> synchronous unlinks.  Use usb_kill_urb() Sep  8 23:13:43 coyote
>> kernel: Badness in usb_unlink_urb at drivers/usb/core/urb.c:456
>> Sep  8 23:13:44 coyote kernel:  [<c01048ce>] dump_stack+0x1e/0x20
>> Sep  8 23:13:44 coyote kernel:  [<c0295f35>]
>> usb_unlink_urb+0x85/0xa0 Sep  8 23:13:44 coyote kernel: 
>> [<c02a7447>] usblp_unlink_urbs+0x17/0x40 Sep  8 23:13:44 coyote
>> kernel:  [<c02a74a8>] usblp_release+0x38/0x60 Sep  8 23:13:44
>> coyote kernel:  [<c01501ea>] __fput+0x12a/0x140 Sep  8 23:13:44
>> coyote kernel:  [<c014e8e7>] filp_close+0x57/0x80 Sep  8 23:13:44
>> coyote kernel:  [<c014e971>] sys_close+0x61/0x90 Sep  8 23:13:44
>> coyote kernel:  [<c010425d>] sysenter_past_esp+0x52/0x71
>>
>> repeat about 40-50 times before I rebooted cause it was very
>> sluggish.
>
>It's not a oops, it's a message that the driver needs to be fixed
> up, and can be ignored safely (but sending a patch to fix the
> driver would be even nicer...)
>
No doubt Greg, if I had a clue about usb things.  Oops or not, that 
reboot took 20x as long as it should have in the shutdown as 
something was seriously eating cpu.  I went to another shell to see 
if top would run, but 2 minutes after I'd typed it, still no top.  
Hence the reboot to -mm2, which has been stable although no optical 
(dvd/cd) recordings have been attempted.

Another question, has anything been done recently that would disable 
amanda?

>thanks,
>
>greg k-h

-- 
Cheers, Gene
"There are four boxes to be used in defense of liberty:
 soap, ballot, jury, and ammo. Please use in that order."
-Ed Howdershelt (Author)
99.25% setiathome rank, not too shabby for a WV hillbilly
Yahoo.com attorneys please note, additions to this message
by Gene Heskett are:
Copyright 2004 by Maurice Eugene Heskett, all rights reserved.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: another oops, this time in 2.6.9-rc1-mm4
  2004-09-09  9:34   ` Borislav Petkov
@ 2004-09-09 17:14     ` Greg KH
  0 siblings, 0 replies; 5+ messages in thread
From: Greg KH @ 2004-09-09 17:14 UTC (permalink / raw)
  To: Borislav Petkov; +Cc: linux-kernel

On Thu, Sep 09, 2004 at 11:34:22AM +0200, Borislav Petkov wrote:
> On Thursday 09 September 2004 08:38, Greg KH wrote:
> > On Thu, Sep 09, 2004 at 01:07:05AM -0400, Gene Heskett wrote:
> > > Greetings;
> > >
> > > I just had to reboot back to -mm2 after playing with some printer configs
> > > in cups, although the test pages worked, so I'm not sure what this all
> > > about, from var log/messages:
> > >
> > > Sep  8 23:13:42 coyote cups: cupsd -HUP succeeded
> > > Sep  8 23:13:43 coyote kernel: usb_unlink_urb() is deprecated for
> > > synchronous unlinks.  Use usb_kill_urb() Sep  8 23:13:43 coyote kernel:
> > > Badness in usb_unlink_urb at drivers/usb/core/urb.c:456 Sep  8 23:13:44
> > > coyote kernel:  [<c01048ce>] dump_stack+0x1e/0x20 Sep  8 23:13:44 coyote
> > > kernel:  [<c0295f35>] usb_unlink_urb+0x85/0xa0 Sep  8 23:13:44 coyote
> > > kernel:  [<c02a7447>] usblp_unlink_urbs+0x17/0x40 Sep  8 23:13:44 coyote
> > > kernel:  [<c02a74a8>] usblp_release+0x38/0x60 Sep  8 23:13:44 coyote
> > > kernel:  [<c01501ea>] __fput+0x12a/0x140
> > > Sep  8 23:13:44 coyote kernel:  [<c014e8e7>] filp_close+0x57/0x80
> > > Sep  8 23:13:44 coyote kernel:  [<c014e971>] sys_close+0x61/0x90
> > > Sep  8 23:13:44 coyote kernel:  [<c010425d>] sysenter_past_esp+0x52/0x71
> > >
> > > repeat about 40-50 times before I rebooted cause it was very sluggish.
> >
> > It's not a oops, it's a message that the driver needs to be fixed up,
> > and can be ignored safely (but sending a patch to fix the driver would
> > be even nicer...)
> >
> > thanks,
> >
> > greg k-h
> > -
> 
> Hi there Greg,
> please be gentle, this is my first time :)
> The situation looked trivial so I thought I should give it a try:

Hm, ok, next time try adding a "Signed-off-by:" line as documented in
Documentation/SubmittingPatches, and make the patch be able to be
applied with the '-p1' option to patch, as that same file details.

But as this was so simple, I took it the way it was, and have applied it
to my trees.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2004-09-09 17:17 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-09-09  5:07 another oops, this time in 2.6.9-rc1-mm4 Gene Heskett
2004-09-09  6:38 ` Greg KH
2004-09-09  9:34   ` Borislav Petkov
2004-09-09 17:14     ` Greg KH
2004-09-09 11:53   ` Gene Heskett

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox