* [PATCH] Obvious compile fix for net/ipv4/ipconfig.c
@ 2004-09-09 19:36 Andre Noll
2004-09-09 20:37 ` Peter Buckingham
0 siblings, 1 reply; 2+ messages in thread
From: Andre Noll @ 2004-09-09 19:36 UTC (permalink / raw)
To: linux-kernel; +Cc: Peter Buckingham, David S. Miller
The undeclared variable in ic_bootp_recv was introduced by Peter's
previous IPCONFIG patch (Logical change 1.21935).
Signed-off-by: Andre Noll <noll@mathematik.tu-darmstadt.de>
Index: linux-2.5/net/ipv4/ipconfig.c
===================================================================
RCS file: /var/cvs/repository/linux-2.5/net/ipv4/ipconfig.c,v
retrieving revision 1.41
diff -u -r1.41 ipconfig.c
--- linux-2.5/net/ipv4/ipconfig.c 8 Sep 2004 19:19:17 -0000 1.41
+++ linux-2.5/net/ipv4/ipconfig.c 9 Sep 2004 19:19:38 -0000
@@ -825,7 +825,7 @@
struct bootp_pkt *b;
struct iphdr *h;
struct ic_device *d;
- int len, ext_len;
+ int len, ext_len, i;
/* Perform verifications before taking the lock. */
if (skb->pkt_type == PACKET_OTHERHOST)
--
Andre Noll, http://www.mathematik.tu-darmstadt.de/~noll
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Obvious compile fix for net/ipv4/ipconfig.c
2004-09-09 19:36 [PATCH] Obvious compile fix for net/ipv4/ipconfig.c Andre Noll
@ 2004-09-09 20:37 ` Peter Buckingham
0 siblings, 0 replies; 2+ messages in thread
From: Peter Buckingham @ 2004-09-09 20:37 UTC (permalink / raw)
To: Andre Noll; +Cc: linux-kernel, David S. Miller
Andre Noll wrote:
> The undeclared variable in ic_bootp_recv was introduced by Peter's
> previous IPCONFIG patch (Logical change 1.21935).
I fixed this by changing the for loop to a memcmp(), I think that this
conveys the intention of the code more clearly. David already accepted
that patch and it should be making it's way upstream as we speak.
peter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-09-09 20:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-09-09 19:36 [PATCH] Obvious compile fix for net/ipv4/ipconfig.c Andre Noll
2004-09-09 20:37 ` Peter Buckingham
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox