Re: [1/1][PATCH] nproc v2: netlink access to /proc information

William Lee Irwin III
2004-09-09T18:56:14Z

On Wed, 08 Sep 2004 17:35:29 -0700, William Lee Irwin III wrote:
>> Any chance you could convert these to use the new vm statistics
>> accounting?

On Thu, Sep 09, 2004 at 08:43:01PM +0200, Roger Luethi wrote:
> Mea culpa. I copied the routines wholesale from 2.6.7 when I started
> work on nproc. They still seemed to work with 2.6.9-rc1-bk13, I hadn't
> noticed the work that had gone into field computation already. So for
> CONFIG_MMU, values in both __task_mem and __task_mem_cheap are cheap
> now. The routines can be merged.
> !CONFIG_MMU is a different story. Presumably, it needs a change in the
> fields that are offered (cp. task_mem in fs/proc/task_nommu.c).
> FWIW, my prefered solution would be to have only one routine task_mem
> to fill the respective struct for nproc and /proc.

I'll follow up shortly with a task_mem()/task_mem_cheap() consolidation
patch atop the others I sent.

On Thu, Sep 09, 2004 at 08:43:01PM +0200, Roger Luethi wrote:
> There seems to be a discrepancy between current task_mem in
> fs/proc/task_nommu.c and the __task_mem{,_cheap} routines you wrote
> for the nproc !CONFIG_MMU case. Can you explain?

I'm not aware of a discrepancy with the fs/proc/task_nommu.c code; I
did, however, have to mangle the things via guesswork to avoid adding
the new fields, which I really wanted you to arrange for or comment on
as they are a matter of interface. Also, could you be more specific
about these discrepancies?

-- wli