From: "David S. Miller" <davem@redhat.com>
To: Brian Somers <brian.somers@sun.com>
Cc: Michael.Waychison@sun.com, linux-kernel@vger.kernel.org
Subject: Re: TG3 doesn't work in kernel 2.4.27 (David S. Miller)
Date: Fri, 10 Sep 2004 13:53:57 -0700 [thread overview]
Message-ID: <20040910135357.393f7737.davem@redhat.com> (raw)
In-Reply-To: <41419F82.10109@sun.com>
On Fri, 10 Sep 2004 13:35:14 +0100
Brian Somers <brian.somers@sun.com> wrote:
> The problem seems to be that autoneg is disabled on the IBM switches.
> After disabling autoneg on the Sun shelf switches, I see the problem.
> This patch fixes things by reverting to sw autoneg which defaults to
> a 1000Mbps/full-duplex link but with no flow control when it fails
> (IBM should really have autoneg enabled!) - I'd appreciate it if
> someone could test this against an IBM blade.
Did you see the fix I posted the other day and have
already merged upstream?
The real problem was the MAC_STATUS register checking in
tg3_timer() that we use to determine if we should call
the PHY code. Specifically, we were failing to test
MAC_STATUS_SIGNAL_DET being set, which when trying to
bring the link up means we should call tg3_setup_phy().
There are still some nagging problems with certain blades even
with my current code. Brian, if you want to help I'd really
appreciate it if you worked with current tg3 sources as I rewrote
the 5704 hw autoneg support from scratch since it was missing
a hw bug workaround and had other issues as well.
Thanks.
next prev parent reply other threads:[~2004-09-10 20:56 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20040816110000.1120.31256.Mailman@lists.us.dell.com>
2004-08-16 11:51 ` TG3 doesn't work in kernel 2.4.27 (David S. Miller) Tetsuo Handa
2004-08-16 21:38 ` David S. Miller
2004-08-25 17:48 ` Mike Waychison
2004-08-25 19:08 ` David S. Miller
2004-08-25 20:04 ` Mike Waychison
2004-08-26 0:58 ` David S. Miller
2004-08-26 10:49 ` Brian Somers
2004-08-26 19:37 ` David S. Miller
2004-08-29 9:56 ` Pekka Pietikainen
2004-09-10 12:35 ` Brian Somers
2004-09-10 19:40 ` Roland Dreier
2004-09-10 20:53 ` David S. Miller [this message]
2004-09-10 21:05 ` Roland Dreier
2004-09-10 21:45 ` David S. Miller
2004-09-10 22:14 ` Brian Somers
2004-08-30 23:11 ` David S. Miller
2004-09-03 19:12 ` Paul Larson
2004-09-03 19:19 ` Mike Waychison
2004-09-03 20:18 ` Roland Dreier
2004-09-03 20:30 ` David S. Miller
2004-09-03 20:40 ` Roland Dreier
2004-09-03 23:24 ` Roland Dreier
2004-09-07 18:33 ` Jake Moilanen
2004-09-07 19:52 ` Roland Dreier
2004-09-08 12:34 ` Jake Moilanen
2004-09-08 13:07 ` Anton Blanchard
2004-09-13 22:48 ` David S. Miller
2004-09-14 22:20 ` Mike Waychison
2004-09-14 22:36 ` David S. Miller
2004-09-14 22:58 ` Jake Moilanen
2004-09-15 0:34 ` Roland Dreier
2004-09-08 13:55 ` Paul Larson
2004-09-10 16:00 ` Paul Larson
2004-09-03 20:08 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040910135357.393f7737.davem@redhat.com \
--to=davem@redhat.com \
--cc=Michael.Waychison@sun.com \
--cc=brian.somers@sun.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox