public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Anton Blanchard <anton@samba.org>
To: linux-kernel@vger.kernel.org
Cc: mingo@elte.hu, viro@parcelfarce.linux.theplanet.co.uk,
	wli@holomorphy.com
Subject: /proc/sys/kernel/pid_max issues
Date: Sun, 12 Sep 2004 18:56:09 +1000	[thread overview]
Message-ID: <20040912085609.GK32755@krispykreme> (raw)


Hi,

I tried creating 100,000 threads just for the hell of it. I was
surprised that it appears to have worked even with pid_max set at 32k.

It seems if we are above pid_max we wrap back to RESERVED_PIDS at the
start of alloc_pidmap but do not enforce this upper limit. I guess every
call of alloc_pidmap above 32k was wrapping back to RESERVED_PIDS,
walking the allocated space then allocating off the end.

Just as an aside, does it make sense to remove the pidmap allocator and
use the IDR allocator now its there?

Now once I had managed to allocate those 100,000 threads, I noticed
this:

18446744071725383682 dr-xr-xr-x   3 root root   0 Sep 12 08:10 100796

Strange huh. Turns out we allocate inodes in proc via:

#define fake_ino(pid,ino) (((pid)<<16)|(ino))

With 32bit inodes we are screwed once pids go over 64k arent we?

Anton

             reply	other threads:[~2004-09-12  8:59 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-09-12  8:56 Anton Blanchard [this message]
2004-09-12  9:36 ` /proc/sys/kernel/pid_max issues William Lee Irwin III
2004-09-12  9:51   ` Ingo Molnar
2004-09-12  9:58   ` William Lee Irwin III
2004-09-12 10:10     ` William Lee Irwin III
2004-09-12 10:13     ` Ingo Molnar
2004-09-12 10:43       ` William Lee Irwin III
2004-09-12 10:45         ` William Lee Irwin III
2004-09-12 11:08           ` William Lee Irwin III
2004-09-12 11:20             ` Ingo Molnar
2004-09-12 17:13               ` William Lee Irwin III
2004-09-12 18:02                 ` Chris Wedgwood
2004-09-12 23:06                   ` William Lee Irwin III
2004-09-13  1:46                 ` [pidhashing] rewrite alloc_pidmap() William Lee Irwin III
2004-09-12  9:39 ` /proc/sys/kernel/pid_max issues Ingo Molnar
2004-09-12  9:43   ` William Lee Irwin III
2004-09-12 12:18 ` Arjan van de Ven
2004-09-12 12:30   ` Anton Blanchard
2004-09-12 12:44     ` Arjan van de Ven
2004-09-12 13:34       ` Anton Blanchard
2004-09-12 13:41       ` Ingo Molnar
  -- strict thread matches above, loose matches on Subject: below --
2004-09-13  3:20 Albert Cahalan
2004-09-13  7:42 ` William Lee Irwin III
2004-09-13 14:11   ` Albert Cahalan
2004-09-13 14:27     ` William Lee Irwin III
2004-09-13 14:51       ` Herbert Poetzl
2004-09-14  2:13         ` William Lee Irwin III
2004-09-23 13:13       ` Pavel Machek
2004-09-24 16:02         ` Martin Mares
2004-09-23 13:11   ` Pavel Machek
2004-09-13  7:57 ` Ingo Molnar
2004-09-13 13:54   ` Albert Cahalan
2004-09-13 14:24     ` William Lee Irwin III
2004-09-13 14:54       ` Albert Cahalan
2004-09-14  2:02         ` William Lee Irwin III
2004-09-14 15:32     ` Ingo Molnar
2004-09-18 18:32       ` Pavel Machek
2004-09-23 13:18     ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040912085609.GK32755@krispykreme \
    --to=anton@samba.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=viro@parcelfarce.linux.theplanet.co.uk \
    --cc=wli@holomorphy.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox