From: William Lee Irwin III <wli@holomorphy.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Anton Blanchard <anton@samba.org>,
linux-kernel@vger.kernel.org,
viro@parcelfarce.linux.theplanet.co.uk
Subject: Re: /proc/sys/kernel/pid_max issues
Date: Sun, 12 Sep 2004 02:43:33 -0700 [thread overview]
Message-ID: <20040912094333.GK2660@holomorphy.com> (raw)
In-Reply-To: <20040912093943.GA10356@elte.hu>
On Sun, Sep 12, 2004 at 11:39:43AM +0200, Ingo Molnar wrote:
> --- linux/kernel/pid.c.orig
> +++ linux/kernel/pid.c
> @@ -103,7 +103,7 @@ int alloc_pidmap(void)
> pidmap_t *map;
>
> pid = last_pid + 1;
> - if (pid >= pid_max)
> + if (unlikely(pid >= pid_max))
> pid = RESERVED_PIDS;
Well, this part won't change the wrapping behavior.
On Sun, Sep 12, 2004 at 11:39:43AM +0200, Ingo Molnar wrote:
> offset = pid & BITS_PER_PAGE_MASK;
> @@ -116,6 +116,10 @@ int alloc_pidmap(void)
> * slowpath and that fixes things up.
> */
> return_pid:
> + if (unlikely(pid >= pid_max)) {
> + clear_bit(offset, map->page);
> + goto failure;
> + }
> atomic_dec(&map->nr_free);
> last_pid = pid;
> return pid;
This is too late; it hands back a hard failure without resetting last_pid.
-- wli
next prev parent reply other threads:[~2004-09-12 9:43 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-12 8:56 /proc/sys/kernel/pid_max issues Anton Blanchard
2004-09-12 9:36 ` William Lee Irwin III
2004-09-12 9:51 ` Ingo Molnar
2004-09-12 9:58 ` William Lee Irwin III
2004-09-12 10:10 ` William Lee Irwin III
2004-09-12 10:13 ` Ingo Molnar
2004-09-12 10:43 ` William Lee Irwin III
2004-09-12 10:45 ` William Lee Irwin III
2004-09-12 11:08 ` William Lee Irwin III
2004-09-12 11:20 ` Ingo Molnar
2004-09-12 17:13 ` William Lee Irwin III
2004-09-12 18:02 ` Chris Wedgwood
2004-09-12 23:06 ` William Lee Irwin III
2004-09-13 1:46 ` [pidhashing] rewrite alloc_pidmap() William Lee Irwin III
2004-09-12 9:39 ` /proc/sys/kernel/pid_max issues Ingo Molnar
2004-09-12 9:43 ` William Lee Irwin III [this message]
2004-09-12 12:18 ` Arjan van de Ven
2004-09-12 12:30 ` Anton Blanchard
2004-09-12 12:44 ` Arjan van de Ven
2004-09-12 13:34 ` Anton Blanchard
2004-09-12 13:41 ` Ingo Molnar
-- strict thread matches above, loose matches on Subject: below --
2004-09-13 3:20 Albert Cahalan
2004-09-13 7:42 ` William Lee Irwin III
2004-09-13 14:11 ` Albert Cahalan
2004-09-13 14:27 ` William Lee Irwin III
2004-09-13 14:51 ` Herbert Poetzl
2004-09-14 2:13 ` William Lee Irwin III
2004-09-23 13:13 ` Pavel Machek
2004-09-24 16:02 ` Martin Mares
2004-09-23 13:11 ` Pavel Machek
2004-09-13 7:57 ` Ingo Molnar
2004-09-13 13:54 ` Albert Cahalan
2004-09-13 14:24 ` William Lee Irwin III
2004-09-13 14:54 ` Albert Cahalan
2004-09-14 2:02 ` William Lee Irwin III
2004-09-14 15:32 ` Ingo Molnar
2004-09-18 18:32 ` Pavel Machek
2004-09-23 13:18 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040912094333.GK2660@holomorphy.com \
--to=wli@holomorphy.com \
--cc=anton@samba.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=viro@parcelfarce.linux.theplanet.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox