From: Andi Kleen <ak@suse.de>
To: Tejun Heo <tj@home-tj.org>
Cc: linux-kernel@vger.kernel.org, zwane@fsmlabs.com
Subject: Re: [PATCH] Interrupt entry CONFIG_FRAME_POINTER fix
Date: Sun, 12 Sep 2004 13:24:54 +0200 [thread overview]
Message-ID: <20040912132454.6cf1d60c.ak@suse.de> (raw)
In-Reply-To: <20040912091628.GB13359@home-tj.org>
On Sun, 12 Sep 2004 18:16:28 +0900
Tejun Heo <tj@home-tj.org> wrote:
> On x86_64, rbp isn't saved on entering interrupt handler even when
> CONFIG_FRAME_POINTER is turned on. This breaks profile_pc()
> (resulting in oops) which uses regs->rbp to track back to the original
> stack. Save full stack when CONFIG_FRAME_POINTER is specified.
I don't think your patch is correct, you don't restore rbp ever and it gets corrupted.
I think the correct change is to fix profile_pc() to not reference rbp, but just hardcode
the rsp offset for the FP and non FP cases (8 and 0)
-Andi
next prev parent reply other threads:[~2004-09-12 11:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-12 9:16 [PATCH] Interrupt entry CONFIG_FRAME_POINTER fix Tejun Heo
2004-09-12 11:24 ` Andi Kleen [this message]
2004-09-12 14:38 ` Tejun Heo
2004-09-12 17:10 ` Zwane Mwaikambo
2004-09-12 18:11 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040912132454.6cf1d60c.ak@suse.de \
--to=ak@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@home-tj.org \
--cc=zwane@fsmlabs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox