From: Alex Zarochentsev <zam@namesys.com>
To: Paul Jackson <pj@sgi.com>
Cc: Hans Reiser <reiser@namesys.com>,
linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>,
William Lee Irwin III <wli@holomorphy.com>
Subject: Re: 2.6.9-rc1-mm4 sparc reiser4 build broken - undefined atomic_sub_and_test
Date: Sun, 12 Sep 2004 20:33:53 +0400 [thread overview]
Message-ID: <20040912163352.GA27411@backtop.namesys.com> (raw)
In-Reply-To: <20040912031235.48c738ae.pj@sgi.com>
On Sun, Sep 12, 2004 at 03:12:35AM -0700, Paul Jackson wrote:
> The default config for sparc on 2.6.9-rc1-mm4 doesn't build, using the
> crosstools from http://developer.osdl.org/dev/plm/cross_compile.
>
> Hans,
>
> Andrew counts on us to build for various arch's, especially when
> submitting something non-trivial. The above crosstools work
> pretty good - give them a try.
>
> The final link fails with:
>
> fs/built-in.o(.text+0x58618): In function `end_io_handler':
> : undefined reference to `atomic_sub_and_test'
> make[1]: *** [arch/sparc/boot/image] Error 1
>
> The macro 'atomic_sub_and_test' is defined for more or less every other
> arch, in various include/asm-*/atomic.h files, but not defined for
> sparc.
It is defined in both asm-sparc/atomic.h and asm-sparc64/atomic.h,
but <asm/atomic.h> was not included into fs/reiser4/flush_queue.c
please try this patch:
=============================
--- reiser4-linux-2.6/fs/reiser4/flush_queue.c.orig 2004-09-12 20:28:10.000000000 +0400
+++ reiser4-linux-2.6/fs/reiser4/flush_queue.c 2004-09-12 20:28:26.000000000 +0400
@@ -11,6 +11,7 @@
#include "vfs_ops.h"
#include "writeout.h"
+#include <asm/atomic.h>
#include <linux/bio.h>
#include <linux/mm.h>
#include <linux/pagemap.h>
===============================
> This macro is used in:
>
> fs/reiser4/flush_queue.c:
> if (atomic_sub_and_test(bio->bi_vcnt, &fq->nr_submitted))
>
> If I disable the config items:
>
> CONFIG_REISER4_FS=y
> CONFIG_REISER4_LARGE_KEY=y
>
> then it builds ok (with the bogus #else removed from cachefs.h, as
> already reported on lkml).
>
> --
> I won't rest till it's the best ...
> Programmer, Linux Scalability
> Paul Jackson <pj@sgi.com> 1.650.933.1373
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
Alex.
next prev parent reply other threads:[~2004-09-12 16:41 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-12 10:12 2.6.9-rc1-mm4 sparc reiser4 build broken - undefined atomic_sub_and_test Paul Jackson
2004-09-12 10:54 ` William Lee Irwin III
2004-09-12 16:33 ` Alex Zarochentsev [this message]
2004-09-12 18:49 ` Paul Jackson
2004-09-12 19:48 ` Alex Zarochentsev
2004-09-13 12:42 ` Hugh Dickins
2004-09-13 13:25 ` Roman Zippel
2004-09-13 13:51 ` Hugh Dickins
2004-09-13 14:10 ` Roman Zippel
2004-09-13 14:58 ` Hugh Dickins
2004-09-13 16:03 ` Roman Zippel
2004-09-13 16:20 ` Hugh Dickins
2004-09-13 20:03 ` Tonnerre
2004-09-13 20:18 ` Roman Zippel
2004-09-13 20:18 ` 2.6.9-rc1-mm4 sparc reiser4 build broken - undefined atomic_s ub_and_test Hugh Dickins
2004-09-13 17:19 ` 2.6.9-rc1-mm4 sparc reiser4 build broken - undefined atomic_sub_and_test Alex Zarochentsev
2004-09-14 2:06 ` William Lee Irwin III
2004-09-14 9:00 ` Roman Zippel
2004-09-14 9:10 ` William Lee Irwin III
2004-09-14 9:15 ` [sparc32] add atomic_sub_and_test() to make reiser4 code microoptimized for x86 compile on sparc32 William Lee Irwin III
2004-09-14 15:38 ` William Lee Irwin III
-- strict thread matches above, loose matches on Subject: below --
2004-09-13 17:14 2.6.9-rc1-mm4 sparc reiser4 build broken - undefined atomic_sub_and_test Martin Schwidefsky
2004-09-13 17:26 ` Roman Zippel
[not found] <OF6D4E73AE.1DB1AD2F-ON42256F0F.003132FF-42256F0F.00321365@de.ibm.com>
2004-09-14 9:40 ` Roman Zippel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040912163352.GA27411@backtop.namesys.com \
--to=zam@namesys.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pj@sgi.com \
--cc=reiser@namesys.com \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox