Re: more numa maxnode confusions

Andi Kleen
2004-09-13T07:23:16Z

On Mon, Sep 13, 2004 at 12:15:48AM -0700, Andrew Morton wrote:
> Andi Kleen <ak@suse.de> wrote:
> >
> > On Sun, Sep 12, 2004 at 08:02:53PM -0700, Paul Jackson wrote:
> > > 2) About Aug 9, Brent Casavant sent in a patch changing the set (not get)
> > > side calls, sys_mbind and sys_set_mempolicy, to N64. This patch
> > > removed the following line from the implementation of get_nodes() in
> > > mm/mempolicy.c:
> > >
> > > --maxnode;
> >
> > Ah, I wasn't aware that this patch got merged into mainline.
> > That was a bad thing, because it broke the ABI used by libnuma
> > subtly.
> >
> > Please whoever merged it revert it.
>
> Revert what?

http://linux.bkbits.net:8080/linux-2.6/cset@412b8943seoOgs2sAUXJeG1qynkYHQ?nav=index.html|src/|src/mm|related/mm/mempolicy.c

>
> > ...
> >
> > Yes. I appended a patch. Linus or Andrew, please apply it.
> >
>
> Does this patch perform the above reversion, or is something additional
> needed?

It does it, and nothing else is needed.

-Andi