From: Paul Jackson <pj@sgi.com>
To: Paul Jackson <pj@sgi.com>
Cc: akpm@osdl.org, ak@suse.de, bcasavan@sgi.com, anton@samba.org,
linux-kernel@vger.kernel.org, torvalds@osdl.org
Subject: [PATCH] undo more numa maxnode confusions
Date: Mon, 13 Sep 2004 05:58:48 -0700 [thread overview]
Message-ID: <20040913055848.1f9d5057.pj@sgi.com> (raw)
In-Reply-To: <20040913014622.3addde90.pj@sgi.com>
Argh ... undo Andi's patch that undid Brent's patch that undid Andi's API ...
It was Linus' bk tree, not Andrew's *-mm tree, that needed the
"--maxnode" put back in. Andrew's tree already has the "--maxnode"
that it should have in the "get_nodes()" routine.
If you apply Andi's patch to Andrew's *-mm tree, then a second nearby
similar looking routine "get_zonemask()" gets the second "--maxnode",
and she doesn't build anymore, failing with:
mm/mempolicy.c: In function `get_zonemask':
mm/mempolicy.c:419: error: `maxnode' undeclared (first use in this function)
This applies on top of 2.6.9-rc1-mm5.
Index: 2.6.9-rc1-mm5/mm/mempolicy.c
===================================================================
--- 2.6.9-rc1-mm5.orig/mm/mempolicy.c 2004-09-13 04:23:57.000000000 -0700
+++ 2.6.9-rc1-mm5/mm/mempolicy.c 2004-09-13 05:00:15.000000000 -0700
@@ -416,7 +416,6 @@ static void get_zonemask(struct mempolic
{
int i;
- --maxnode;
bitmap_zero(nodes, MAX_NUMNODES);
switch (p->policy) {
case MPOL_BIND:
--
I won't rest till it's the best ...
Programmer, Linux Scalability
Paul Jackson <pj@sgi.com> 1.650.933.1373
prev parent reply other threads:[~2004-09-13 13:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-13 3:02 more numa maxnode confusions Paul Jackson
2004-09-13 6:56 ` Andi Kleen
2004-09-13 7:08 ` Paul Jackson
2004-09-13 7:15 ` Andrew Morton
2004-09-13 7:23 ` Andi Kleen
2004-09-13 8:46 ` Paul Jackson
2004-09-13 12:58 ` Paul Jackson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040913055848.1f9d5057.pj@sgi.com \
--to=pj@sgi.com \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=anton@samba.org \
--cc=bcasavan@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox