From: Adrian Bunk <bunk@fs.tum.de>
To: Marcelo Tosatti <marcelo.tosatti@cyclades.com>, ipslinux@adaptec.com
Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: 2.4.28-pre3: broken ips update
Date: Mon, 13 Sep 2004 09:03:35 +0200 [thread overview]
Message-ID: <20040913070334.GD1937@fs.tum.de> (raw)
In-Reply-To: <20040911220117.GA4669@logos.cnet>
On Sat, Sep 11, 2004 at 07:01:17PM -0300, Marcelo Tosatti wrote:
>...
> Summary of changes from v2.4.28-pre2 to v2.4.28-pre3
> ============================================
>...
> Jack Hammer:
> o ServeRAID driver (ips) Version 7.10.18
>...
<-- snip -->
...
gcc-3.4 -D__KERNEL__
-I/home/bunk/linux/kernel-2.4/linux-2.4.28-pre3-full/include -Wall
-Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common
-fomit-frame-pointer -pipe -mpreferred-stack-boundary=2 -march=athlon
-fno-unit-at-a-time -nostdinc -iwithprefix include
-DKBUILD_BASENAME=ips -c -o ips.o ips.c
In file included from ips.c:190:
ips.h:101: error: redefinition of typedef 'irqreturn_t'
/home/bunk/linux/kernel-2.4/linux-2.4.28-pre3-full/include/linux/interrupt.h:16:
error: previous declaration of 'irqreturn_t' was here
make[3]: *** [ips.o] Error 1
make[3]: Leaving directory `/home/bunk/linux/kernel-2.4/linux-2.4.28-pre3-full/drivers/scsi'
<-- snip -->
This update was obviously submitted without even testing the compilation
of the driver (not to mention testing whether it actually works).
Even worse:
We had _exactly the same problem_ with the 7.00.15 driver in
2.4.27-pre3, but 7.10.18 now simply reverts my (trivial) fix for this
compile error.
Marcelo, can you please refuse patches from people who don't bother to
do even the simplest compile testing when blindly submitting the latest
version of a driver?
TIA
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2004-09-13 7:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-11 22:01 Linux 2.4.28-pre3 Marcelo Tosatti
2004-09-13 7:03 ` Adrian Bunk [this message]
2004-09-13 14:24 ` 2.4.28-pre3: broken ips update Mikael Pettersson
-- strict thread matches above, loose matches on Subject: below --
2004-09-13 14:28 Hammer, Jack
2004-09-13 14:42 ` Matthew Wilcox
2004-09-13 14:46 ` Arjan van de Ven
2004-09-13 15:00 Hammer, Jack
2004-09-13 18:01 Hammer, Jack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040913070334.GD1937@fs.tum.de \
--to=bunk@fs.tum.de \
--cc=ipslinux@adaptec.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=marcelo.tosatti@cyclades.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox