Re: [PATCH] fix reiser4 compilation for ->permission changes

Christoph Hellwig
2004-09-13T17:20:27Z

On Mon, Sep 13, 2004 at 09:09:11PM +0400, Alex Zarochentsev wrote:
> > ->permission is the only access checking method for filesystems,
> > everything else is supposed to happen through LSM which may use xattr
> > storage in the filesystem.
>
> I think what reiser4 needs is exactly the fs-specific per-object permission
> check. Is i_op->permission() going to be obsolete? If not, ->permission()
> is the best (available) way to call reiser4 permission plugin methods.

Currently there is no permission checking in reiser4 that's different
from generic_permission so don't set a ->permission. If you ever have
more checking set it for those objects that want more checking instead
of such a useless indirection.