Re: [PATCH] fix reiser4 compilation for ->permission changes

Alex Zarochentsev
2004-09-13T17:17:13Z

On Mon, Sep 13, 2004 at 04:04:40PM +0200, Christoph Hellwig wrote:
> On Mon, Sep 13, 2004 at 04:02:26PM +0200, Christoph Hellwig wrote:
> > remove reiser4 permission. It only ends up calling generic_permission
> > with no additional bits so it's completely unessecary.
>

> Actually not. I'm lost in the CPP abuse in reiser4, sorry. Could someone of
> the namesys folks please remove all the perm_plugin mess?

yes, if you mean that check_perm() macro.

> ->permission is the only access checking method for filesystems,
> everything else is supposed to happen through LSM which may use xattr
> storage in the filesystem.

I think what reiser4 needs is exactly the fs-specific per-object permission
check. Is i_op->permission() going to be obsolete? If not, ->permission()
is the best (available) way to call reiser4 permission plugin methods.

> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/

--
Alex.