Re: [1/1][PATCH] nproc v2: netlink access to /proc information

Albert Cahalan
2004-09-11T22:28:41Z

On Thu, 2004-09-09 at 15:11, Roger Luethi wrote:
> On Thu, 09 Sep 2004 11:49:33 -0700, William Lee Irwin III wrote:
> > I'll follow up shortly with a task_mem()/task_mem_cheap() consolidation
> > patch atop the others I sent.
>
> I have a few minor changes coming up as well.
>
> One nitpick: As vmexe and vmlib are always 0 for !CONFIG_MMU, we should
> ifdef them out of the list of offered fields for that configuration (and
> maybe in nproc_ps_field as well).

No. First of all, I think they can be offered. Until proven
otherwise, I'll assume that the !CONFIG_MMU case is buggy.

Second of all, removal will make the !CONFIG_MMU systems
less compatible with the rest of the world. This will
mean that fewer apps can run on !CONFIG_MMU boxes. It's
same problem as "All the world's a VAX". It's better that
the apps work; an author working on a Pentium 4 Xeon is
likely to write code that relies on the fields and might
not really understand what "no MMU" is all about.