From: William Lee Irwin III <wli@holomorphy.com>
To: Roman Zippel <zippel@linux-m68k.org>
Cc: Alex Zarochentsev <zam@namesys.com>,
Hugh Dickins <hugh@veritas.com>, Paul Jackson <pj@sgi.com>,
Hans Reiser <reiser@namesys.com>,
linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>,
Martin Schwidefsky <schwidefsky@de.ibm.com>
Subject: Re: 2.6.9-rc1-mm4 sparc reiser4 build broken - undefined atomic_sub_and_test
Date: Tue, 14 Sep 2004 02:10:45 -0700 [thread overview]
Message-ID: <20040914091045.GL9106@holomorphy.com> (raw)
In-Reply-To: <Pine.LNX.4.61.0409141055000.877@scrub.home>
On Mon, 13 Sep 2004, William Lee Irwin III wrote:
>> sparc32 is very legacy;
On Tue, Sep 14, 2004 at 11:00:50AM +0200, Roman Zippel wrote:
> Sparc is not really relevant in this case, as it basically uses
> atomic_sub_return() anyway, but i386 or m68k can benefit from avoiding
> atomic_sub_return() if it's possible and that not only in reiserfs.
The only point I had to make was that I'd rather avoid adding arch
hooks for code that will never be run on the arch. I suppose for the
sake of compiletesting...
-- wli
Add atomic_sub_and_test() to sparc32, implemented in terms of
atomic_sub_return(), so reiser4 can be simultaneously microoptimized
and made to pass compilation testing on sparc32.
Index: mm5-2.6.9-rc1/include/asm-sparc/atomic.h
===================================================================
--- mm5-2.6.9-rc1.orig/include/asm-sparc/atomic.h 2004-08-13 22:37:25.000000000 -0700
+++ mm5-2.6.9-rc1/include/asm-sparc/atomic.h 2004-09-14 01:59:51.579542880 -0700
@@ -46,6 +46,7 @@
#define atomic_inc_and_test(v) (atomic_inc_return(v) == 0)
#define atomic_dec_and_test(v) (atomic_dec_return(v) == 0)
+#define atomic_sub_and_test(v) (atomic_sub_return(v) == 0)
/* This is the old 24-bit implementation. It's still used internally
* by some sparc-specific code, notably the semaphore implementation.
next prev parent reply other threads:[~2004-09-14 9:12 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-12 10:12 2.6.9-rc1-mm4 sparc reiser4 build broken - undefined atomic_sub_and_test Paul Jackson
2004-09-12 10:54 ` William Lee Irwin III
2004-09-12 16:33 ` Alex Zarochentsev
2004-09-12 18:49 ` Paul Jackson
2004-09-12 19:48 ` Alex Zarochentsev
2004-09-13 12:42 ` Hugh Dickins
2004-09-13 13:25 ` Roman Zippel
2004-09-13 13:51 ` Hugh Dickins
2004-09-13 14:10 ` Roman Zippel
2004-09-13 14:58 ` Hugh Dickins
2004-09-13 16:03 ` Roman Zippel
2004-09-13 16:20 ` Hugh Dickins
2004-09-13 20:03 ` Tonnerre
2004-09-13 20:18 ` Roman Zippel
2004-09-13 20:18 ` 2.6.9-rc1-mm4 sparc reiser4 build broken - undefined atomic_s ub_and_test Hugh Dickins
2004-09-13 17:19 ` 2.6.9-rc1-mm4 sparc reiser4 build broken - undefined atomic_sub_and_test Alex Zarochentsev
2004-09-14 2:06 ` William Lee Irwin III
2004-09-14 9:00 ` Roman Zippel
2004-09-14 9:10 ` William Lee Irwin III [this message]
2004-09-14 9:15 ` [sparc32] add atomic_sub_and_test() to make reiser4 code microoptimized for x86 compile on sparc32 William Lee Irwin III
2004-09-14 15:38 ` William Lee Irwin III
-- strict thread matches above, loose matches on Subject: below --
2004-09-13 17:14 2.6.9-rc1-mm4 sparc reiser4 build broken - undefined atomic_sub_and_test Martin Schwidefsky
2004-09-13 17:26 ` Roman Zippel
[not found] <OF6D4E73AE.1DB1AD2F-ON42256F0F.003132FF-42256F0F.00321365@de.ibm.com>
2004-09-14 9:40 ` Roman Zippel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040914091045.GL9106@holomorphy.com \
--to=wli@holomorphy.com \
--cc=akpm@osdl.org \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pj@sgi.com \
--cc=reiser@namesys.com \
--cc=schwidefsky@de.ibm.com \
--cc=zam@namesys.com \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox