From: Christoph Hellwig <hch@infradead.org>
To: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: hch@lst.df, akpm@osdl.org, spyro@f2s.com, rmk@arm.linux.org.uk,
linux390@de.ibm.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] irq_enter/irq_exit consolidation
Date: Tue, 14 Sep 2004 19:31:35 +0100 [thread overview]
Message-ID: <20040914193135.A10776@infradead.org> (raw)
In-Reply-To: <20040913130239.GA3086@mschwid3.boeblingen.de.ibm.com>; from schwidefsky@de.ibm.com on Mon, Sep 13, 2004 at 03:02:40PM +0200
On Mon, Sep 13, 2004 at 03:02:40PM +0200, Martin Schwidefsky wrote:
> Hi Christoph,
>
> > s390 has an assembly wrapper around do_softirq.
> >
> > I've extended the invoke_softirq mechanism used by s390 (also called
> > by ksoftirqd) to the two arm variants, but the right thing to do is
> > probably to use the normal do_softirq call in arm and set
> > __ARCH_HAS_DO_SOFTIRQ + providing a per-arch do_softirq for all callers
> > for s390 and maybe arm26.
>
> do_call_softirq switches to the asynchronous interrupt stack,
> just what i386 does now as well. Trouble is that on s390 it is
> non-trivial to do the switch in C with inline assembly. We need
> a bit of assembly. But we could get rid of invoke_softirq, define
> __ARCH_HAS_DO_SOFTIRQ and use do_softirq to call the assembly
> wrapper.
Well, the question is do you want the direct do_softirq invocations from
the networking code use the separate stack or not? If not the current
code is fine. If yes you should sent the patch to Andrew.
next prev parent reply other threads:[~2004-09-14 18:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-13 13:02 [PATCH] irq_enter/irq_exit consolidation Martin Schwidefsky
2004-09-14 18:31 ` Christoph Hellwig [this message]
-- strict thread matches above, loose matches on Subject: below --
2004-09-12 11:25 Christoph Hellwig
2004-09-12 11:44 ` Russell King
2004-09-12 22:57 ` David S. Miller
2004-09-13 8:10 ` Russell King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040914193135.A10776@infradead.org \
--to=hch@infradead.org \
--cc=akpm@osdl.org \
--cc=hch@lst.df \
--cc=linux-kernel@vger.kernel.org \
--cc=linux390@de.ibm.com \
--cc=rmk@arm.linux.org.uk \
--cc=schwidefsky@de.ibm.com \
--cc=spyro@f2s.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox