public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: William Lee Irwin III <wli@holomorphy.com>
To: Chris Friesen <cfriesen@nortelnetworks.com>
Cc: Linux kernel <linux-kernel@vger.kernel.org>
Subject: Re: offtopic: how to break huge patch into smaller independent patches?
Date: Tue, 14 Sep 2004 13:11:57 -0700	[thread overview]
Message-ID: <20040914201157.GJ9106@holomorphy.com> (raw)
In-Reply-To: <41474B15.8040302@nortelnetworks.com>

On Tue, Sep 14, 2004 at 01:48:37PM -0600, Chris Friesen wrote:
> Its kind of offtopic, but I hoped that someone might have some pointers 
> since the kernel developers deal with so many patches.
> I've been given a massive kernel patch that makes a whole bunch of 
> conceptually independent changes.
> Does anyone have any advice on how to break it up into independent patches?

It's hard work. It's sometimes even harder than writing the patch
itself. To handle this, I would:

(a) identify the conceptually independent changes
(b) rewrite the conceptually independent changes separately in series
(c) look for the results of (b) that are too large, and try to find
	some way to represent them as a series conceptually independent
	changes.
(d) if (c) returned a nonzero number of results, recurse to (b)

Yes, this means you have to rewrite the stuff altogether. This is not
quite as hard as it sounds, as you can largely "discover" what the
rewrites should be by filtering changes. But it's still relatively hard.

Identifying conceptually independent changes has no universal rules, so
that may also be hard.


-- wli

  reply	other threads:[~2004-09-14 20:18 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-09-14 19:48 offtopic: how to break huge patch into smaller independent patches? Chris Friesen
2004-09-14 20:11 ` William Lee Irwin III [this message]
2004-09-14 20:12 ` Dave Jones
2004-09-14 22:12   ` J. Bruce Fields
2004-09-16 21:11   ` Matthias Urlichs
2004-09-16 21:21     ` Herbert Poetzl
2004-09-15  0:20 ` Anton Blanchard
2004-09-15  0:47   ` Martin J. Bligh
2004-09-15  1:24     ` Chris Friesen
2004-09-15  1:47       ` Andreas Dilger
2004-09-15  4:36         ` Chris Friesen
2004-09-15  5:27           ` Martin J. Bligh
2004-09-15 11:48             ` Arnd Bergmann
2004-09-15 23:05           ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040914201157.GJ9106@holomorphy.com \
    --to=wli@holomorphy.com \
    --cc=cfriesen@nortelnetworks.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox