public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "J. Bruce Fields" <bfields@fieldses.org>
To: Dave Jones <davej@redhat.com>,
	Chris Friesen <cfriesen@nortelnetworks.com>,
	Linux kernel <linux-kernel@vger.kernel.org>
Subject: Re: offtopic: how to break huge patch into smaller independent patches?
Date: Tue, 14 Sep 2004 18:12:04 -0400	[thread overview]
Message-ID: <20040914221204.GA24015@fieldses.org> (raw)
In-Reply-To: <20040914201210.GE13788@redhat.com>

On Tue, Sep 14, 2004 at 09:12:10PM +0100, Dave Jones wrote:
> On Tue, Sep 14, 2004 at 01:48:37PM -0600, Chris Friesen wrote:
>  > 
>  > Its kind of offtopic, but I hoped that someone might have some pointers 
>  > since the kernel developers deal with so many patches.
>  > 
>  > I've been given a massive kernel patch that makes a whole bunch of 
>  > conceptually independent changes.
>  > 
>  > Does anyone have any advice on how to break it up into independent patches?
> 
> diffsplit will split it into a patch-per-file, which could be
> a good start. If you have multiple changes touching the same file
> however, things get a bit more fun, and you get to spend a lot
> of time in your favorite text editor glueing bits together.

When I've done this I've started by taking big patch P against tree T,
finding the simplest, easiest to understand change in it, writing a
small patch P_0 which makes that one change, then diffing T + P against

	T + P_0

(where "T + P_0" means "the result of applying patch P_0 to tree T").
Repeat, write a second patch P_1, and diff T + P against

	T + P_0 + P_1

So at step n+1, I find out what's left to do by diffing T + P against

	T + P_0 + ... + P_n

(where I'm actually maintaining the patches P_i using Andrew Morton's
patch scripts).

Given a tree, a big patch, and a series of little patches (more
generally, given *two* series of patches) I'd like to be able to
calculate the diff between the two quickly.  Not having any automated
way to do that makes this all more of a pain than it should be.

It seems like it shouldn't be hard to do this with some shell scripting,
but I haven't sat down and tried it yet.  I'd be interested to hear if
anyone else as.

--Bruce Fields

  reply	other threads:[~2004-09-14 22:16 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-09-14 19:48 offtopic: how to break huge patch into smaller independent patches? Chris Friesen
2004-09-14 20:11 ` William Lee Irwin III
2004-09-14 20:12 ` Dave Jones
2004-09-14 22:12   ` J. Bruce Fields [this message]
2004-09-16 21:11   ` Matthias Urlichs
2004-09-16 21:21     ` Herbert Poetzl
2004-09-15  0:20 ` Anton Blanchard
2004-09-15  0:47   ` Martin J. Bligh
2004-09-15  1:24     ` Chris Friesen
2004-09-15  1:47       ` Andreas Dilger
2004-09-15  4:36         ` Chris Friesen
2004-09-15  5:27           ` Martin J. Bligh
2004-09-15 11:48             ` Arnd Bergmann
2004-09-15 23:05           ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040914221204.GA24015@fieldses.org \
    --to=bfields@fieldses.org \
    --cc=cfriesen@nortelnetworks.com \
    --cc=davej@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox