From: Marc Ballarin <Ballarin.Marc@gmx.de>
To: Peter Jones <pjones@redhat.com>
Cc: axboe@suse.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] allow root to modify raw scsi command permissions list
Date: Wed, 15 Sep 2004 00:43:32 +0200 [thread overview]
Message-ID: <20040915004332.6fe581f5.Ballarin.Marc@gmx.de> (raw)
In-Reply-To: <1095173470.5728.3.camel@localhost.localdomain>
On Tue, 14 Sep 2004 10:51:10 -0400
Peter Jones <pjones@redhat.com> wrote:
Good to see someone do this. I tried myself but didn't get very far.
> diff -urpN linux-2.5-export/drivers/block/genhd.c pjones-2.5-export/drivers/block/genhd.c
...
> };
> +static struct disk_attribute disk_attribute_driver = {
This obviously needs to be
+static struct disk_attribute disk_attr_driver = {
otherwise the following part won't work:
> @@ -409,6 +422,7 @@ static struct attribute * default_attrs[
> &disk_attr_removable.attr,
> &disk_attr_size.attr,
> &disk_attr_stat.attr,
> + &disk_attr_driver.attr,
> NULL,
> };
Additionally, the naming "rawio_cmd_filter" and RCF_* seems a bit
confusing (after all raw IO usually refers to O_DIRECT file access).
"sg_cmd_filter" and SGF_* appear to be a better choice IMHO.
How should changes to the table be made? I suppose something like "echo
add 04 > ok_read_commands". But rcf_store doesn't seem to get called. Am I
missing something?
Regards, and thanks for this patch
next prev parent reply other threads:[~2004-09-14 22:40 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-14 14:51 [PATCH] allow root to modify raw scsi command permissions list Peter Jones
2004-09-14 22:43 ` Marc Ballarin [this message]
2004-09-15 17:08 ` Peter Jones
2004-09-15 19:14 ` Kai Makisara
2004-09-15 19:49 ` Peter Jones
2004-09-15 20:49 ` Kai Makisara
2004-09-15 19:50 ` Jens Axboe
2004-09-15 20:32 ` Peter Jones
2004-09-16 9:33 ` Marc Ballarin
2004-09-15 21:08 ` [PATCH-NEW] " Marc Ballarin
2004-09-15 21:38 ` Alan Cox
2004-09-15 23:03 ` Peter Jones
2004-09-15 22:23 ` Alan Cox
2004-09-15 23:33 ` Marc Ballarin
2004-09-15 23:36 ` Peter Jones
2004-09-16 12:21 ` Marc Ballarin
2004-09-16 15:10 ` Marc Ballarin
2004-09-16 17:36 ` Peter Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040915004332.6fe581f5.Ballarin.Marc@gmx.de \
--to=ballarin.marc@gmx.de \
--cc=axboe@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=pjones@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox