From: Marc Ballarin <Ballarin.Marc@gmx.de>
To: Peter Jones <pjones@redhat.com>
Cc: alan@lxorguk.ukuu.org.uk, axboe@suse.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH-NEW] allow root to modify raw scsi command permissions list
Date: Thu, 16 Sep 2004 14:21:09 +0200 [thread overview]
Message-ID: <20040916142109.6fc7223c.Ballarin.Marc@gmx.de> (raw)
In-Reply-To: <1095291378.5945.4.camel@localhost.localdomain>
On Wed, 15 Sep 2004 19:36:18 -0400
Peter Jones <pjones@redhat.com> wrote:
> Yes.
>
> Here's another version of the patch. It does what yours did, as well as
> that. It also combines the read and write code so there's one of each,
> with a parameter to tell which it's supposed to modify.
Looks *slightly* better than mine ;-)
But
> +static ssize_t rcf_cmds_store(struct rawio_cmd_filter *rcf, const char *page,
> + size_t count, int rw)
...
> + ss.from = (char *)page+ret;
> + ss.to = (char *)page+ret+1;
needs to be
> + ss.from = (char *)page+ret;
> + ss.to = (char *)page+ret+2;
Regards
next prev parent reply other threads:[~2004-09-16 12:07 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-14 14:51 [PATCH] allow root to modify raw scsi command permissions list Peter Jones
2004-09-14 22:43 ` Marc Ballarin
2004-09-15 17:08 ` Peter Jones
2004-09-15 19:14 ` Kai Makisara
2004-09-15 19:49 ` Peter Jones
2004-09-15 20:49 ` Kai Makisara
2004-09-15 19:50 ` Jens Axboe
2004-09-15 20:32 ` Peter Jones
2004-09-16 9:33 ` Marc Ballarin
2004-09-15 21:08 ` [PATCH-NEW] " Marc Ballarin
2004-09-15 21:38 ` Alan Cox
2004-09-15 23:03 ` Peter Jones
2004-09-15 22:23 ` Alan Cox
2004-09-15 23:33 ` Marc Ballarin
2004-09-15 23:36 ` Peter Jones
2004-09-16 12:21 ` Marc Ballarin [this message]
2004-09-16 15:10 ` Marc Ballarin
2004-09-16 17:36 ` Peter Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040916142109.6fc7223c.Ballarin.Marc@gmx.de \
--to=ballarin.marc@gmx.de \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=axboe@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=pjones@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox