From: Duncan Sands <baldrick@free.fr>
To: Stelian Pop <stelian@popies.net>
Cc: Hugh Dickins <hugh@veritas.com>, Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org
Subject: Re: [RFC, 2.6] a simple FIFO implementation
Date: Fri, 17 Sep 2004 15:16:24 +0200 [thread overview]
Message-ID: <200409171516.24840.baldrick@free.fr> (raw)
In-Reply-To: <20040917130532.GA22386@sd291.sivit.org>
> > Hi Stelian, what is to stop the compiler putting, say, "in" in a register
> > for the process calling __kfifo_get, so that it only sees a constant
> > value. Then after a while that process will think there is nothing
> > to get even though another process is shoving stuff into the fifo and
> > modifying "in".
>
> This can happen all right, but the buffer (or the indices) will not
> get corrupt (this is what I call coherent). Its just like the __kfifo_get()
> was executed entirely before the __kfifo_put().
Hi Stelian, that's not how I read the comment
+ * Note that with only one concurrent reader and one concurrent
+ * writer, you don't need extra locking to use these functions.
so maybe it is better to avoid confusion and be more explicit here.
Ciao,
Duncan.
next prev parent reply other threads:[~2004-09-17 13:16 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-13 13:52 [RFC, 2.6] a simple FIFO implementation Stelian Pop
2004-09-15 10:20 ` Stelian Pop
2004-09-15 11:10 ` Tonnerre
2004-09-15 11:25 ` Alan Cox
2004-09-15 13:27 ` Dmitry Torokhov
2004-09-15 14:21 ` Stelian Pop
2004-09-15 22:30 ` Andrew Morton
2004-09-16 6:43 ` Stelian Pop
2004-09-16 7:04 ` Andrew Morton
2004-09-16 10:45 ` Stelian Pop
2004-09-16 13:57 ` Paul Jackson
2004-09-16 14:09 ` Stelian Pop
2004-09-16 15:45 ` Paul Jackson
2004-09-16 15:59 ` Stelian Pop
2004-09-16 15:09 ` Buddy Lucas
2004-09-16 15:29 ` Stelian Pop
2004-09-16 15:51 ` Buddy Lucas
2004-09-16 15:52 ` Stelian Pop
2004-09-16 16:07 ` Buddy Lucas
2004-09-16 18:30 ` Stelian Pop
2004-09-16 22:52 ` Buddy Lucas
2004-09-16 17:00 ` Andrew Morton
2004-09-16 18:09 ` Stelian Pop
2004-09-17 0:18 ` Andrew Morton
2004-09-17 10:24 ` Stelian Pop
2004-09-17 11:28 ` Paul Jackson
2004-09-17 11:44 ` Hugh Dickins
2004-09-17 12:24 ` Stelian Pop
2004-09-17 12:37 ` Duncan Sands
2004-09-17 12:48 ` Stelian Pop
2004-09-17 13:00 ` Duncan Sands
2004-09-17 13:05 ` Stelian Pop
2004-09-17 13:16 ` Duncan Sands [this message]
2004-09-17 13:15 ` Andrea Arcangeli
2004-09-17 13:36 ` Stelian Pop
2004-09-17 13:41 ` Andrea Arcangeli
2004-09-17 14:00 ` Stelian Pop
2004-09-17 15:14 ` Andrea Arcangeli
2004-09-17 14:47 ` Paul Jackson
2004-09-17 12:52 ` James R Bruce
2004-09-17 15:48 ` Stelian Pop
2004-09-17 16:01 ` Andrea Arcangeli
2004-09-17 16:14 ` Hugh Dickins
2004-09-17 20:50 ` Stelian Pop
2004-09-17 21:28 ` Andrea Arcangeli
2004-09-17 21:54 ` Ryan Cumming
2004-09-17 22:00 ` Andrea Arcangeli
2004-09-17 22:14 ` Ryan Cumming
2004-09-17 22:35 ` Andrew Morton
2004-09-18 0:07 ` Ryan Cumming
2004-09-17 22:29 ` Ryan Cumming
2004-09-18 3:41 ` Kyle Moffett
2004-09-18 7:56 ` Ryan Cumming
2004-09-17 22:07 ` Andrew Morton
2004-09-20 15:14 ` Stelian Pop
2004-09-20 18:01 ` Sasha Khapyorsky
2004-09-20 18:22 ` Stelian Pop
2004-09-20 19:00 ` Richard B. Johnson
2004-09-16 15:57 ` Bill Davidsen
2004-09-17 10:25 ` Stelian Pop
[not found] <260353727@toto.iv>
2004-09-17 1:00 ` Peter Chubb
2004-09-17 5:45 ` Chris Friesen
2004-09-17 11:58 ` Anton Blanchard
2004-09-17 10:32 ` Stelian Pop
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200409171516.24840.baldrick@free.fr \
--to=baldrick@free.fr \
--cc=akpm@osdl.org \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stelian@popies.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox