* [patch] bttv bugfix
@ 2004-09-20 12:45 Gerd Knorr
0 siblings, 0 replies; only message in thread
From: Gerd Knorr @ 2004-09-20 12:45 UTC (permalink / raw)
To: Andrew Morton, Kernel List
Hi,
This fixes a initialization order bug in bttv, also known as "dark red
image bug". Please apply,
Gerd
diff -u linux-2.6.9-rc2/drivers/media/video/bttv-driver.c linux/drivers/media/video/bttv-driver.c
--- linux-2.6.9-rc2/drivers/media/video/bttv-driver.c 2004-09-17 14:56:37.000000000 +0200
+++ linux/drivers/media/video/bttv-driver.c 2004-09-20 14:41:47.563654821 +0200
@@ -1052,11 +1052,6 @@
btwrite(whitecrush_upper, BT848_WC_UP);
btwrite(whitecrush_lower, BT848_WC_DOWN);
- bt848_bright(btv, btv->bright);
- bt848_hue(btv, btv->hue);
- bt848_contrast(btv, btv->contrast);
- bt848_sat(btv, btv->saturation);
-
if (btv->opt_lumafilter) {
btwrite(0, BT848_E_CONTROL);
btwrite(0, BT848_O_CONTROL);
@@ -1065,6 +1060,11 @@
btwrite(BT848_CONTROL_LDEC, BT848_O_CONTROL);
}
+ bt848_bright(btv, btv->bright);
+ bt848_hue(btv, btv->hue);
+ bt848_contrast(btv, btv->contrast);
+ bt848_sat(btv, btv->saturation);
+
/* interrupt */
init_irqreg(btv);
}
--
return -ENOSIG;
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2004-09-20 13:01 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-09-20 12:45 [patch] bttv bugfix Gerd Knorr
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox