* Unaligned kernel access in crypto/sha1.c
@ 2004-09-16 23:16 H. J. Lu
2004-09-18 5:11 ` Andrew Morton
0 siblings, 1 reply; 4+ messages in thread
From: H. J. Lu @ 2004-09-16 23:16 UTC (permalink / raw)
To: linux kernel, linux ia64 kernel
I got
Sep 16 15:45:32 gnu-2 kernel: kernel unaligned access to
0xa0000002001c008e, ip=0xa0000001002135e0
Sep 16 15:45:37 gnu-2 kernel: kernel unaligned access to
0xa0000002002d005e, ip=0xa0000001002135e0
Sep 16 15:45:37 gnu-2 kernel: kernel unaligned access to
0xa0000002002d006e, ip=0xa0000001002135e0
Sep 16 15:45:37 gnu-2 kernel: kernel unaligned access to
0xa0000002002d007e, ip=0xa0000001002135e0
Sep 16 15:45:37 gnu-2 kernel: kernel unaligned access to
0xa0000002002d008e, ip=0xa0000001002135e0
on ia64 from sha1_transform in crypto/sha1.c:
/* Hash a single 512-bit block. This is the core of the algorithm. */
static void sha1_transform(u32 *state, const u8 *in)
{
u32 a, b, c, d, e;
u32 block32[16];
/* convert/copy data to workspace */
for (a = 0; a < sizeof(block32)/sizeof(u32); a++)
block32[a] = be32_to_cpu (((const u32 *)in)[a]);
^^^^^^^^^^^^^^^^
This may not be aligned for u32 on ia64.
H.J.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: Unaligned kernel access in crypto/sha1.c
2004-09-16 23:16 Unaligned kernel access in crypto/sha1.c H. J. Lu
@ 2004-09-18 5:11 ` Andrew Morton
2004-09-20 18:16 ` H. J. Lu
0 siblings, 1 reply; 4+ messages in thread
From: Andrew Morton @ 2004-09-18 5:11 UTC (permalink / raw)
To: H. J. Lu; +Cc: linux-kernel, linux-ia64
"H. J. Lu" <hjl@lucon.org> wrote:
>
> I got
>
> Sep 16 15:45:32 gnu-2 kernel: kernel unaligned access to
> 0xa0000002001c008e, ip=0xa0000001002135e0
> Sep 16 15:45:37 gnu-2 kernel: kernel unaligned access to
> 0xa0000002002d005e, ip=0xa0000001002135e0
> Sep 16 15:45:37 gnu-2 kernel: kernel unaligned access to
> 0xa0000002002d006e, ip=0xa0000001002135e0
> Sep 16 15:45:37 gnu-2 kernel: kernel unaligned access to
> 0xa0000002002d007e, ip=0xa0000001002135e0
> Sep 16 15:45:37 gnu-2 kernel: kernel unaligned access to
> 0xa0000002002d008e, ip=0xa0000001002135e0
>
> on ia64 from sha1_transform in crypto/sha1.c:
>
> /* Hash a single 512-bit block. This is the core of the algorithm. */
> static void sha1_transform(u32 *state, const u8 *in)
> {
> u32 a, b, c, d, e;
> u32 block32[16];
>
> /* convert/copy data to workspace */
> for (a = 0; a < sizeof(block32)/sizeof(u32); a++)
> block32[a] = be32_to_cpu (((const u32 *)in)[a]);
> ^^^^^^^^^^^^^^^^
> This may not be aligned for u32 on ia64.
>
>
We really need to know the call trace here.
--- 25/arch/ia64/kernel/unaligned.c~ia64-alignment-error-stack-dump 2004-09-17 22:10:14.933111832 -0700
+++ 25-akpm/arch/ia64/kernel/unaligned.c 2004-09-17 22:10:35.903923784 -0700
@@ -1342,9 +1342,11 @@ ia64_handle_unaligned (unsigned long ifa
printk(KERN_WARNING "%s", buf); /* watch for command names containing %s */
}
} else {
- if (within_logging_rate_limit())
+ if (within_logging_rate_limit()) {
printk(KERN_WARNING "kernel unaligned access to 0x%016lx, ip=0x%016lx\n",
ifa, regs->cr_iip + ipsr->ri);
+ dump_stack();
+ }
set_fs(KERNEL_DS);
}
_
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: Unaligned kernel access in crypto/sha1.c
2004-09-18 5:11 ` Andrew Morton
@ 2004-09-20 18:16 ` H. J. Lu
2004-09-20 18:35 ` Andrew Morton
0 siblings, 1 reply; 4+ messages in thread
From: H. J. Lu @ 2004-09-20 18:16 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel, linux-ia64
On Fri, Sep 17, 2004 at 10:11:08PM -0700, Andrew Morton wrote:
> "H. J. Lu" <hjl@lucon.org> wrote:
> >
> > I got
> >
> > Sep 16 15:45:32 gnu-2 kernel: kernel unaligned access to
> > 0xa0000002001c008e, ip=0xa0000001002135e0
> > Sep 16 15:45:37 gnu-2 kernel: kernel unaligned access to
> > 0xa0000002002d005e, ip=0xa0000001002135e0
> > Sep 16 15:45:37 gnu-2 kernel: kernel unaligned access to
> > 0xa0000002002d006e, ip=0xa0000001002135e0
> > Sep 16 15:45:37 gnu-2 kernel: kernel unaligned access to
> > 0xa0000002002d007e, ip=0xa0000001002135e0
> > Sep 16 15:45:37 gnu-2 kernel: kernel unaligned access to
> > 0xa0000002002d008e, ip=0xa0000001002135e0
> >
> > on ia64 from sha1_transform in crypto/sha1.c:
> >
> > /* Hash a single 512-bit block. This is the core of the algorithm. */
> > static void sha1_transform(u32 *state, const u8 *in)
> > {
> > u32 a, b, c, d, e;
> > u32 block32[16];
> >
> > /* convert/copy data to workspace */
> > for (a = 0; a < sizeof(block32)/sizeof(u32); a++)
> > block32[a] = be32_to_cpu (((const u32 *)in)[a]);
> > ^^^^^^^^^^^^^^^^
> > This may not be aligned for u32 on ia64.
> >
> >
>
> We really need to know the call trace here.
>
This is from a kernel with signed module support.
kernel unaligned access to 0xa0000002002e47ee, ip=0xa000000100211960
Call Trace:
[<a000000100017490>] show_stack+0x90/0xc0
sp=e00000017b8cf610
bsp=e00000017b8c9330
[<a0000001000174f0>] dump_stack+0x30/0x60
sp=e00000017b8cf7e0
bsp=e00000017b8c9318
[<a000000100043100>] ia64_handle_unaligned+0x540/0x2600
sp=e00000017b8cf7e0
bsp=e00000017b8c9290
[<a0000001000101b0>] ia64_prepare_handle_unaligned+0x30/0x60
sp=e00000017b8cf990
bsp=e00000017b8c9290
[<a00000010000fbe0>] ia64_leave_kernel+0x0/0x260
sp=e00000017b8cfba0
bsp=e00000017b8c9290
[<a000000100211960>] sha1_transform+0x60/0x3160
sp=e00000017b8cfd70
bsp=e00000017b8c9128
[<a000000100214c60>] sha1_update+0x120/0x1a0
sp=e00000017b8cfda0
bsp=e00000017b8c90e0
[<a00000010020fd40>] update_kernel+0x60/0x100
sp=e00000017b8cfda0
bsp=e00000017b8c90b0
[<a0000001000b3340>] module_verify_sig+0x660/0x740
sp=e00000017b8cfda0
bsp=e00000017b8c8ff0
[<a0000001000aed80>] load_module+0x7e0/0x2ba0
sp=e00000017b8cfda0
bsp=e00000017b8c8ec0
[<a0000001000b1220>] sys_init_module+0xe0/0x640
sp=e00000017b8cfe30
bsp=e00000017b8c8e50
[<a00000010000fa80>] ia64_ret_from_syscall+0x0/0x20
sp=e00000017b8cfe30
bsp=e00000017b8c8e50
[<a000000000010620>] 0xa000000000010620
sp=e00000017b8d0000
bsp=e00000017b8c8e50
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: Unaligned kernel access in crypto/sha1.c
2004-09-20 18:16 ` H. J. Lu
@ 2004-09-20 18:35 ` Andrew Morton
0 siblings, 0 replies; 4+ messages in thread
From: Andrew Morton @ 2004-09-20 18:35 UTC (permalink / raw)
To: H. J. Lu; +Cc: linux-kernel, linux-ia64
"H. J. Lu" <hjl@lucon.org> wrote:
>
> On Fri, Sep 17, 2004 at 10:11:08PM -0700, Andrew Morton wrote:
> > "H. J. Lu" <hjl@lucon.org> wrote:
> > >
> > > I got
> > >
> > > Sep 16 15:45:32 gnu-2 kernel: kernel unaligned access to
> > > 0xa0000002001c008e, ip=0xa0000001002135e0
> > > Sep 16 15:45:37 gnu-2 kernel: kernel unaligned access to
> > > 0xa0000002002d005e, ip=0xa0000001002135e0
> > > Sep 16 15:45:37 gnu-2 kernel: kernel unaligned access to
> > > 0xa0000002002d006e, ip=0xa0000001002135e0
> > > Sep 16 15:45:37 gnu-2 kernel: kernel unaligned access to
> > > 0xa0000002002d007e, ip=0xa0000001002135e0
> > > Sep 16 15:45:37 gnu-2 kernel: kernel unaligned access to
> > > 0xa0000002002d008e, ip=0xa0000001002135e0
> > >
> > > on ia64 from sha1_transform in crypto/sha1.c:
> > >
> > > /* Hash a single 512-bit block. This is the core of the algorithm. */
> > > static void sha1_transform(u32 *state, const u8 *in)
> > > {
> > > u32 a, b, c, d, e;
> > > u32 block32[16];
> > >
> > > /* convert/copy data to workspace */
> > > for (a = 0; a < sizeof(block32)/sizeof(u32); a++)
> > > block32[a] = be32_to_cpu (((const u32 *)in)[a]);
> > > ^^^^^^^^^^^^^^^^
> > > This may not be aligned for u32 on ia64.
> > >
> > >
> >
> > We really need to know the call trace here.
> >
>
> This is from a kernel with signed module support.
>
> kernel unaligned access to 0xa0000002002e47ee, ip=0xa000000100211960
>
> Call Trace:
> [<a000000100017490>] show_stack+0x90/0xc0
> sp=e00000017b8cf610
> bsp=e00000017b8c9330
> [<a0000001000174f0>] dump_stack+0x30/0x60
> sp=e00000017b8cf7e0
> bsp=e00000017b8c9318
> [<a000000100043100>] ia64_handle_unaligned+0x540/0x2600
> sp=e00000017b8cf7e0
> bsp=e00000017b8c9290
> [<a0000001000101b0>] ia64_prepare_handle_unaligned+0x30/0x60
> sp=e00000017b8cf990
> bsp=e00000017b8c9290
> [<a00000010000fbe0>] ia64_leave_kernel+0x0/0x260
> sp=e00000017b8cfba0
> bsp=e00000017b8c9290
> [<a000000100211960>] sha1_transform+0x60/0x3160
> sp=e00000017b8cfd70
> bsp=e00000017b8c9128
> [<a000000100214c60>] sha1_update+0x120/0x1a0
> sp=e00000017b8cfda0
> bsp=e00000017b8c90e0
> [<a00000010020fd40>] update_kernel+0x60/0x100
> sp=e00000017b8cfda0
> bsp=e00000017b8c90b0
> [<a0000001000b3340>] module_verify_sig+0x660/0x740
> sp=e00000017b8cfda0
The bug is in either module_verify_sig() or in update_kernel().
Neither of these functions are present in kernel.org kernels, so there's
some sort of lesson there.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2004-09-20 18:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-09-16 23:16 Unaligned kernel access in crypto/sha1.c H. J. Lu
2004-09-18 5:11 ` Andrew Morton
2004-09-20 18:16 ` H. J. Lu
2004-09-20 18:35 ` Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox