From: Linas Vepstas <linas@austin.ibm.com>
To: Denis Vlasenko <vda@port.imtp.ilyichevsk.odessa.ua>
Cc: paulus@samba.org, linux-kernel@vger.kernel.org, anton@samba.org
Subject: Re: [PATCH] [PPC64] [TRIVIAL] Janitor whitespace in pSeries_pci.c
Date: Tue, 21 Sep 2004 11:12:16 -0500 [thread overview]
Message-ID: <20040921161216.GD1872@austin.ibm.com> (raw)
In-Reply-To: <200409211407.09764.vda@port.imtp.ilyichevsk.odessa.ua>
On Tue, Sep 21, 2004 at 02:07:09PM +0300, Denis Vlasenko was heard to remark:
> On Tuesday 21 September 2004 01:31, Linas Vepstas wrote:
> >
> > Forgot to attach the actual patch.
> >
> > On Mon, Sep 20, 2004 at 05:19:33PM -0500, Linas Vepstas was heard to remark:
> > > Hi,
> >
> >
> > This file mixes tabs with 8 spaces, leading to poor display
> > if one's editor doesn't have tab-stops set to 8. Please apply.
>
> There are lots of such places.
> Automated scripts can easily produce megabytes worth of whitespace
> patches.
>
> As I understand, such patches aren't accepted because
> merging pain is much greater than gain.
> Typically whitespace cleanups are piggybacked on some code changes.
Last time I sent in a combined whitespace plus other-fixes patch,
I was asked to do the opposite, and split them apart. I'm just
trying to do the right thing; I have other pending patches for this
file, and I'm waiting for the backlog to clear out before I submit
those.
--linas
next prev parent reply other threads:[~2004-09-21 16:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-20 22:19 [PATCH] [PPC64] [TRIVIAL] Janitor whitespace in pSeries_pci.c Linas Vepstas
2004-09-20 22:31 ` Linas Vepstas
2004-09-21 11:07 ` Denis Vlasenko
2004-09-21 16:12 ` Linas Vepstas [this message]
2004-09-22 23:17 ` Herbert Poetzl
2004-09-23 0:29 ` Linas Vepstas
2004-09-23 15:36 ` Paul Mackerras
2004-09-23 16:08 ` Herbert Poetzl
2004-09-25 16:55 ` Denis Vlasenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040921161216.GD1872@austin.ibm.com \
--to=linas@austin.ibm.com \
--cc=anton@samba.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulus@samba.org \
--cc=vda@port.imtp.ilyichevsk.odessa.ua \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox