public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Nishanth Aravamudan <nacc@us.ibm.com>
To: Adrian Bunk <bunk@fs.tum.de>
Cc: kj <kernel-janitors@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: 2.6.9-rc2-kjt1 rio_linux compile error
Date: Wed, 22 Sep 2004 09:22:18 -0700	[thread overview]
Message-ID: <20040922162218.GB1924@us.ibm.com> (raw)
In-Reply-To: <20040922112157.GB27364@fs.tum.de>

On Wed, Sep 22, 2004 at 01:21:58PM +0200, Adrian Bunk wrote:
> On Wed, Sep 22, 2004 at 12:13:07AM +0200, maximilian attems wrote:
> >...
> > added since 2.6.9-rc1-kjt1
> >...
> > msleep-drivers_char_rio_linux.patch
> >   From: Nishanth Aravamudan <nacc@us.ibm.com>
> >   Subject: [Kernel-janitors] [PATCH 2.6.9-rc2 20/33] char/rio_linux: replace 	schedule_timeout() with msleep()/msleep_interruptible()
> >...
> 
> This doesn't compile (obvious typo):

Thanks for catching this! Here is the fixed patch:


--- 2.6.9-rc2-vanilla/drivers/char/rio/rio_linux.c	2004-09-13 17:15:47.000000000 -0700
+++ 2.6.9-rc2/drivers/char/rio/rio_linux.c	2004-09-22 09:20:56.000000000 -0700
@@ -330,8 +330,7 @@ int RIODelay (struct Port *PortP, int nj
   func_enter ();
 
   rio_dprintk (RIO_DEBUG_DELAY, "delaying %d jiffies\n", njiffies);  
-  current->state = TASK_INTERRUPTIBLE;
-  schedule_timeout(njiffies);
+  msleep_interruptible(jiffies_to_msecs(njiffies));
   func_exit();
 
   if (signal_pending(current))
@@ -347,8 +346,7 @@ int RIODelay_ni (struct Port *PortP, int
   func_enter ();
 
   rio_dprintk (RIO_DEBUG_DELAY, "delaying %d jiffies (ni)\n", njiffies);  
-  current->state = TASK_UNINTERRUPTIBLE;
-  schedule_timeout(njiffies);
+  msleep(jiffies_to_msecs(njiffies));
   func_exit();
   return !RIO_FAIL;
 }

  reply	other threads:[~2004-09-22 16:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-09-21 22:13 [announce] 2.6.9-rc2-kjt1 maximilian attems
2004-09-22 11:21 ` 2.6.9-rc2-kjt1 rio_linux compile error Adrian Bunk
2004-09-22 16:22   ` Nishanth Aravamudan [this message]
2004-09-22 18:26     ` [Kernel-janitors] " maximilian attems

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040922162218.GB1924@us.ibm.com \
    --to=nacc@us.ibm.com \
    --cc=bunk@fs.tum.de \
    --cc=kernel-janitors@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox