public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: James Bottomley <James.Bottomley@SteelEye.com>
Cc: Rusty Russell <rusty@rustcorp.com.au>,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	SCSI Mailing List <linux-scsi@vger.kernel.org>,
	linux-usb-devel@lists.sourceforge.net
Subject: Re: [RFC] put symbolic links between drivers and modules in the sysfs tree
Date: Wed, 22 Sep 2004 16:06:50 -0700	[thread overview]
Message-ID: <20040922230650.GB14279@kroah.com> (raw)
In-Reply-To: <20040922230423.GA14279@kroah.com>

On Wed, Sep 22, 2004 at 04:04:23PM -0700, Greg KH wrote:
> I'll post my usb core change after this, to show you how USB can
> be hooked up to it.

And here's the 3 line patch that I added to the usb core to hook up both
the usb and usb-serial drivers to support the modules symlinks.

I'll go mess with the pci core now, but as there is no "struct module *"
in the pci driver structure, it will take a bit of auditing to get them
all hooked up properly.

thanks,

greg k-h

------


USB: add support for symlink from usb and usb-serial driver to its module in sysfs

Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>

diff -Nru a/drivers/usb/core/usb.c b/drivers/usb/core/usb.c
--- a/drivers/usb/core/usb.c	2004-09-22 15:56:44 -07:00
+++ b/drivers/usb/core/usb.c	2004-09-22 15:56:44 -07:00
@@ -76,6 +76,7 @@
 }
 
 static struct device_driver usb_generic_driver = {
+	.owner = THIS_MODULE,
 	.name =	"usb",
 	.bus = &usb_bus_type,
 	.probe = generic_probe,
@@ -159,6 +160,7 @@
 	new_driver->driver.bus = &usb_bus_type;
 	new_driver->driver.probe = usb_probe_interface;
 	new_driver->driver.remove = usb_unbind_interface;
+	new_driver->driver.owner = new_driver->owner;
 
 	usb_lock_all_devices();
 	retval = driver_register(&new_driver->driver);
diff -Nru a/drivers/usb/serial/bus.c b/drivers/usb/serial/bus.c
--- a/drivers/usb/serial/bus.c	2004-09-22 15:56:44 -07:00
+++ b/drivers/usb/serial/bus.c	2004-09-22 15:56:44 -07:00
@@ -120,6 +120,7 @@
 	device->driver.bus = &usb_serial_bus_type;
 	device->driver.probe = usb_serial_device_probe;
 	device->driver.remove = usb_serial_device_remove;
+	device->driver.owner = device->owner;
 
 	retval = driver_register(&device->driver);
 

  reply	other threads:[~2004-09-22 23:07 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-09-20 17:29 [RFC] put symbolic links between drivers and modules in the sysfs tree James Bottomley
2004-09-22 23:04 ` Greg KH
2004-09-22 23:06   ` Greg KH [this message]
2004-09-22 23:40     ` Greg KH
2004-09-25  7:38 ` viro
2004-09-25  8:05   ` Herbert Xu
2004-09-25  8:21     ` Arjan van de Ven
2004-09-25 13:16       ` James Bottomley
2004-09-25 13:14   ` James Bottomley
2004-09-26 10:37     ` Herbert Xu
2004-09-26 13:09       ` James Bottomley
2004-09-25 16:46   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040922230650.GB14279@kroah.com \
    --to=greg@kroah.com \
    --cc=James.Bottomley@SteelEye.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linux-usb-devel@lists.sourceforge.net \
    --cc=rusty@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox