public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Lukas Hejtmanek <xhejtman@mail.muni.cz>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: 2.6.9-rc2-mm2 fn_hash_insert oops
Date: Thu, 23 Sep 2004 12:37:23 +0200	[thread overview]
Message-ID: <20040923103723.GA12145@mail.muni.cz> (raw)
In-Reply-To: <20040923031451.56147952.akpm@osdl.org>

On Thu, Sep 23, 2004 at 03:14:51AM -0700, Andrew Morton wrote:
> Lukas Hejtmanek <xhejtman@mail.muni.cz> wrote:
> >
> > Sep 23 11:26:24 debian kernel: EIP:    0060:[fn_hash_insert+1039/1159]    Tainted:  P   VLI
> > 
> 
> This might fix it
> 
> --- a/net/ipv4/fib_hash.c	2004-09-23 03:13:49 -07:00
> +++ b/net/ipv4/fib_hash.c	2004-09-23 03:13:49 -07:00
> @@ -536,7 +536,7 @@
>  		 * information.
>  		 */
>  		fa_orig = fa;
> -		list_for_each_entry(fa, fa->fa_list.prev, fa_list) {
> +		list_for_each_entry(fa, fa_orig->fa_list.prev, fa_list) {
>  			if (fa->fa_info->fib_priority != fi->fib_priority)
>  				break;
>  			if (fa->fa_type == type &&

It has fixed it.

However there is still the issue with endless loop in fn_hash_delete :(

-- 
Lukáš Hejtmánek

  parent reply	other threads:[~2004-09-23 10:37 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-09-23 10:09 2.6.9-rc2-mm2 fn_hash_insert oops Lukas Hejtmanek
2004-09-23 10:14 ` Andrew Morton
2004-09-23 10:23   ` Lukas Hejtmanek
2004-09-23 10:37   ` Lukas Hejtmanek [this message]
2004-09-23 10:48     ` Andrew Morton
2004-09-23 11:16     ` Herbert Xu
2004-09-23 14:02       ` Lukas Hejtmanek
2004-09-23 19:18       ` Ingo Molnar
2004-09-23 20:36       ` David S. Miller
2004-09-23 23:29         ` Martin Diehl
2004-09-23 21:38       ` Nuno Ferreira

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040923103723.GA12145@mail.muni.cz \
    --to=xhejtman@mail.muni.cz \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox