From: Jakub Jelinek <jakub@redhat.com>
To: "Mr. Berkley Shands" <berkley@dssimail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: sendfile64() on x86_64 breaks at 2gb (MAX_NON_LFS limit)
Date: Thu, 23 Sep 2004 13:28:18 -0400 [thread overview]
Message-ID: <20040923172818.GX31909@devserv.devel.redhat.com> (raw)
In-Reply-To: <41530349.2050003@dssimail.com>
On Thu, Sep 23, 2004 at 12:09:29PM -0500, Mr. Berkley Shands wrote:
> for the opteron, the value of MAX_NON_LFS (include/linux/fs.h) is fixed
> at (1UL<<31 -1).
> Since ALL 64 bit boxes force O_LARGEFILE on, shouldn't this value be
> (1UL<<63 -1) so that
> sendfile64() will proceed beyond the 2gb limit?
> under 2.6.6, sendfile64() has no __NR_sendfile64 entry in asm*/unistd.h
> (same for 2.6.9-rc2)
> so the syscall sendfile64() maps to sendfile(), which has MAX_NON_LFS
> hard coded in fs/read_write.c
> as its limit, rather than 0ULL as in sendfile64().
>
> So the fix is to make the correct entry for sendfile64 in unistd.h (note
> that this hoses /usr/include/.../syscalls.h :-)
> and update fs.h as folows:
No. You want the MAX_NON_LFS limit for 32-bit programs that call sendfile()
(as opposed to sendfile64()) on 64-bit arches.
The correct fix which is in the kernel for a few months is:
http://linux.bkbits.net:8080/linux-2.5/diffs/include/asm-x86_64/unistd.h@1.25
Jakub
prev parent reply other threads:[~2004-09-23 18:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-23 17:09 sendfile64() on x86_64 breaks at 2gb (MAX_NON_LFS limit) Mr. Berkley Shands
2004-09-23 17:28 ` Jakub Jelinek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040923172818.GX31909@devserv.devel.redhat.com \
--to=jakub@redhat.com \
--cc=berkley@dssimail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox