* [patch 2/3] __FUNCTION__ string concatenation
@ 2004-09-23 21:22 janitor
2004-09-23 21:24 ` maximilian attems
0 siblings, 1 reply; 2+ messages in thread
From: janitor @ 2004-09-23 21:22 UTC (permalink / raw)
To: akpm; +Cc: linux-kernel, janitor, drizzd
I've replaced the __FUNCTION__ string concatenation with the
%s placeholder and a printf parameter in
drivers/net/wireless/prism65/islpci_mgt.h, as suggested in the TODO
list.
I don't have the hardware to do a run-time check. It should not pose any
problems though.
# This is a BitKeeper generated diff -Nru style patch.
#
# ChangeSet
# 2004/07/04 22:08:37+02:00 drizzd@aon.at
# __FUNCTION__ string concatenation is deprecated
#
# drivers/net/wireless/prism54/islpci_mgt.h
# 2004/07/03 17:18:20+02:00 drizzd@aon.at +1 -1
# __FUNCTION__ string concatenation is deprecated
#
Signed-off-by: Maximilian Attems <janitor@sternwelten.at>
---
linux-2.6.9-rc2-bk7-max/drivers/net/wireless/prism54/islpci_mgt.h | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
diff -puN drivers/net/wireless/prism54/islpci_mgt.h~printk-net_wireless_prism54_islpci_mgt.h drivers/net/wireless/prism54/islpci_mgt.h
--- linux-2.6.9-rc2-bk7/drivers/net/wireless/prism54/islpci_mgt.h~printk-net_wireless_prism54_islpci_mgt.h 2004-09-21 20:47:57.000000000 +0200
+++ linux-2.6.9-rc2-bk7-max/drivers/net/wireless/prism54/islpci_mgt.h 2004-09-21 20:47:57.000000000 +0200
@@ -31,7 +31,7 @@
#define K_DEBUG(f, m, args...) do { if(f & m) printk(KERN_DEBUG args); } while(0)
#define DEBUG(f, args...) K_DEBUG(f, pc_debug, args)
-#define TRACE(devname) K_DEBUG(SHOW_TRACING, VERBOSE, "%s: -> " __FUNCTION__ "()\n", devname)
+#define TRACE(devname) K_DEBUG(SHOW_TRACING, VERBOSE, "%s: -> %s()\n", devname, __FUNCTION__)
extern int pc_debug;
#define init_wds 0 /* help compiler optimize away dead code */
_
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [patch 2/3] __FUNCTION__ string concatenation
2004-09-23 21:22 [patch 2/3] __FUNCTION__ string concatenation janitor
@ 2004-09-23 21:24 ` maximilian attems
0 siblings, 0 replies; 2+ messages in thread
From: maximilian attems @ 2004-09-23 21:24 UTC (permalink / raw)
To: akpm; +Cc: linux-kernel, drizzd
On Thu, 23 Sep 2004, janitor@sternwelten.at wrote:
>
>
> I've replaced the __FUNCTION__ string concatenation with the
> %s placeholder and a printf parameter in
> drivers/net/wireless/prism65/islpci_mgt.h, as suggested in the TODO
> list.
>
> I don't have the hardware to do a run-time check. It should not pose any
> problems though.
>
argh that one is wrong please forget that single one.
thanks maks
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-09-23 21:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-09-23 21:22 [patch 2/3] __FUNCTION__ string concatenation janitor
2004-09-23 21:24 ` maximilian attems
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox