From: Greg KH <greg@kroah.com>
To: Christoph Hellwig <hch@infradead.org>,
Hanna Linder <hannal@us.ibm.com>,
linux-kernel@vger.kernel.org, kernel-janitors@lists.osdl.org,
davej@codemonkey.org.uk, hpa@zytor.com
Subject: Re: [PATCH 2.6.9-rc2-mm2] Create new function to see if pci dev is present
Date: Fri, 24 Sep 2004 14:19:12 -0700 [thread overview]
Message-ID: <20040924211912.GC7619@kroah.com> (raw)
In-Reply-To: <20040924200231.A30391@infradead.org>
On Fri, Sep 24, 2004 at 08:02:31PM +0100, Christoph Hellwig wrote:
> On Thu, Sep 23, 2004 at 03:26:40PM -0700, Hanna Linder wrote:
> >
> > Greg asked in a previous janitors thread:
> > "What we need is a simple "Is this pci device present right now" type
> > function, to solve the mess that logic like this needs."
> >
> > OK. How about this one? It uses pci_get_device but instead of returning
> > the dev it returns 1 if the device is present and 0 if it isnt. This take the
> > burdon off the driver from having to know when to use pci_dev_put or
> > not and should be cleaner for future maintenance work.
> >
> > Ive tested it with two patches that will follow.
>
> Please include subdevice/subvendor id
Good idea, but do you see any places in the kernel that would use those
fields, instead of always setting them to PCI_ANY_ID?
thanks,
greg k-h
next prev parent reply other threads:[~2004-09-24 21:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-23 22:26 [PATCH 2.6.9-rc2-mm2] Create new function to see if pci dev is present Hanna Linder
2004-09-23 22:50 ` Greg KH
2004-09-24 19:02 ` Christoph Hellwig
2004-09-24 21:19 ` Greg KH [this message]
2004-09-24 21:00 ` Alan Cox
2004-09-26 14:10 ` Greg KH
2004-09-28 17:24 ` Greg KH
2004-09-28 17:25 ` Greg KH
2004-09-28 17:26 ` Greg KH
2004-09-24 21:26 ` [PATCH 2.6.9-rc2-mm2] " H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040924211912.GC7619@kroah.com \
--to=greg@kroah.com \
--cc=davej@codemonkey.org.uk \
--cc=hannal@us.ibm.com \
--cc=hch@infradead.org \
--cc=hpa@zytor.com \
--cc=kernel-janitors@lists.osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox