From: Tonnerre <tonnerre@thundrix.ch>
To: William Lee Irwin III <wli@holomorphy.com>
Cc: Albert Cahalan <albert@users.sf.net>,
linux-kernel mailing list <linux-kernel@vger.kernel.org>,
rth@twiddle.net
Subject: Re: __attribute__((always_inline)) fiasco
Date: Sun, 26 Sep 2004 03:29:25 +0200 [thread overview]
Message-ID: <20040926012925.GA14305@thundrix.ch> (raw)
In-Reply-To: <20040923165026.GF9106@holomorphy.com>
[-- Attachment #1: Type: text/plain, Size: 626 bytes --]
Salut,
On Thu, Sep 23, 2004 at 09:50:26AM -0700, William Lee Irwin III wrote:
> On Thu, Sep 23, 2004 at 12:26:18PM -0400, Albert Cahalan wrote:
> > #define INLINE static inline // an oxymoron
> > #define INLINE extern inline // an oxymoron
>
> The // apart from being a C++ ism (screw C99; it's still non-idiomatic)
> will cause spurious ignorance of the remainder of the line, which is
> often very important. e.g.
>
> static INLINE int lock_need_resched(spinlock_t *lock)
> {
> ...
Mmm, shouldn't the comments be filtered *before* the definition is set
in place? Just wondering...
Tonnerre
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2004-09-26 1:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-23 16:26 __attribute__((always_inline)) fiasco Albert Cahalan
2004-09-23 16:50 ` William Lee Irwin III
2004-09-23 16:59 ` Albert Cahalan
2004-09-23 17:03 ` Richard Henderson
2004-09-23 17:21 ` viro
2004-09-23 17:33 ` William Lee Irwin III
2004-09-23 17:39 ` viro
2004-09-26 1:29 ` Tonnerre [this message]
2004-09-26 2:05 ` William Lee Irwin III
2004-09-30 16:19 ` Bill Davidsen
2004-09-23 16:54 ` Richard Henderson
2004-09-23 17:46 ` Albert Cahalan
-- strict thread matches above, loose matches on Subject: below --
2004-09-23 8:47 Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040926012925.GA14305@thundrix.ch \
--to=tonnerre@thundrix.ch \
--cc=albert@users.sf.net \
--cc=linux-kernel@vger.kernel.org \
--cc=rth@twiddle.net \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox