From: Andi Kleen <ak@suse.de>
To: "Mallick, Asit K" <asit.k.mallick@intel.com>,
"Siddha, Suresh B" <suresh.b.siddha@intel.com>,
tom.l.nguyen@intel.com, linux-kernel@vger.kernel.org
Subject: [PATCH] Fix x86-64 properly with MSI & Suresh's change
Date: Mon, 27 Sep 2004 12:41:47 +0200 [thread overview]
Message-ID: <20040927104147.GE3532@wotan.suse.de> (raw)
Together with Suresh's recent LH workaround: this patch makes x86-64
compile again with MSI on. i386 uses an CPU number, x86-64
an CPU mask for MSI_TARGET_CPUS and that didn't work very well.
I must admit I don't fully understand how MSI irq affinity
is supposed to work (why do you always redirect to the current CPU?),
but this matches i386 which is presumably the best tested MSI
platform.
Signed-off-by: Andi Kleen <ak@suse.de>
diff -u linux/include/asm-x86_64/msi.h-o linux/include/asm-x86_64/msi.h
--- linux/include/asm-x86_64/msi.h-o 2004-09-24 13:04:06.000000000 +0200
+++ linux/include/asm-x86_64/msi.h 2004-09-27 12:19:56.000000000 +0200
@@ -7,10 +7,11 @@
#define ASM_MSI_H
#include <asm/desc.h>
+#include <asm/smp.h>
#define LAST_DEVICE_VECTOR 232
#define MSI_DEST_MODE MSI_LOGICAL_MODE
#define MSI_TARGET_CPU_SHIFT 12
-#define MSI_TARGET_CPU TARGET_CPUS
+#define MSI_TARGET_CPU hard_smp_processor_id()
#endif /* ASM_MSI_H */
reply other threads:[~2004-09-27 10:42 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040927104147.GE3532@wotan.suse.de \
--to=ak@suse.de \
--cc=asit.k.mallick@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=suresh.b.siddha@intel.com \
--cc=tom.l.nguyen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox