* Re: PATCH: TTY ldisc and termios locking work
[not found] <20040927143047.GA2921@devserv.devel.redhat.com>
@ 2004-09-27 15:34 ` Linus Torvalds
2004-09-27 15:41 ` Alan Cox
0 siblings, 1 reply; 2+ messages in thread
From: Linus Torvalds @ 2004-09-27 15:34 UTC (permalink / raw)
To: Alan Cox; +Cc: Andrew Morton, Kernel Mailing List
Alan,
this seems to be corrupted. A quick read-through found this in
generic_serial.c:
+ ld = tty_ldisc_ref(tty);
+ if (ld != NULL) {
+ ld->flush_buffer)
+ ld->flush_buffer(tty);
+ tty_ldisc_deref(ld);
+ }
I can see the missing "if (" in my mind, but I'm wondering what else I
might have missed. Ie can we have this patch be tested a bit more first?
Linus
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: PATCH: TTY ldisc and termios locking work
2004-09-27 15:34 ` PATCH: TTY ldisc and termios locking work Linus Torvalds
@ 2004-09-27 15:41 ` Alan Cox
0 siblings, 0 replies; 2+ messages in thread
From: Alan Cox @ 2004-09-27 15:41 UTC (permalink / raw)
To: Linus Torvalds; +Cc: Alan Cox, Andrew Morton, Kernel Mailing List
On Mon, Sep 27, 2004 at 08:34:50AM -0700, Linus Torvalds wrote:
> + ld = tty_ldisc_ref(tty);
> + if (ld != NULL) {
> + ld->flush_buffer)
> + ld->flush_buffer(tty);
> + tty_ldisc_deref(ld);
> + }
>
> I can see the missing "if (" in my mind, but I'm wondering what else I
> might have missed. Ie can we have this patch be tested a bit more first?
Its been running for several days. generic_serial got missed because its
BROKEN_ON_SMP for all users and so never got built. Fixed in my tree now.
Alan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-09-27 15:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20040927143047.GA2921@devserv.devel.redhat.com>
2004-09-27 15:34 ` PATCH: TTY ldisc and termios locking work Linus Torvalds
2004-09-27 15:41 ` Alan Cox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox